Return string value of Some or blank in Option<T>.ToString() #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renders Option<T>.ToString() consistent with Nullable<T>.ToString() and easier to substitute for.
atifaziz
force-pushed
the
option-maybe-val-tostr
branch
from
2c08dec to
c9b9959
Compare
atifaziz
force-pushed
the
option-maybe-val-tostr
branch
from
69b3d63 to
f4668ce
Compare
This was referenced Dec 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you approved of the idea laid out in #17, thought I'd submit a PR. 😄
All unit tests are green.
Style-wise, let me know if you'd rather have the
ToStringimplementation expanded to a full-blown if-else statement.