Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the pub identifier requirement. #485

Merged

Conversation

kalaspuffar
Copy link
Collaborator

Hi @martinpub

I've commented out the requirement to have unique-identifier set to pub-identifier.

Best regards
Daniel

@martinpub
Copy link
Collaborator

Thanks @kalaspuffar!

For information, the reason that this is removed is that currently, Pipeline 2 EPUB generation does not preserve the name of the connecting attribute "pub-identifier", while still preserving integrity between dc:identifier and unique-identifier. A relaxation has been suggested in daisy/pipeline#612.

It should be noted that already EPUBCheck verifies the presence of unique-identifier on the root element of package.opf, and that it is pointing to a corresponding meta tag with an ID.

We can get back to discussing this, after summer, but this will solve a production block at MTM and given the discussion above, the removal is not considered dangerous.

@martinpub martinpub merged commit daccd22 into nlbdev:guidelines-revision Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants