Fix a bug in the deprecation decorator, update the screenshot

nkolev92 · Sep 12, 2023 · 9c92b7f · 9c92b7f
1 parent 4d09719
commit 9c92b7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/resources/DependencyGraphExample.jpg b/resources/DependencyGraphExample.jpg
diff --git a/src/Common/DeprecationInfoDecorator.cs b/src/Common/DeprecationInfoDecorator.cs
@@ -27,7 +27,7 @@ public async Task DecorateAsync(PackageDependencyNode dependencyNode, Cancellati
                 return;
             }
 
-            if (_packageMetadataResourcesAcquired)
+            if (!_packageMetadataResourcesAcquired)
             {
                 await InitializeMetadataResource(cancellationToken);
                 _packageMetadataResourcesAcquired = true;
@@ -60,7 +60,11 @@ private async Task<bool> IsPackageDeprecatedAsync(PackageIdentity packageIdentit
             {
                 if (result?.Result != null)
                 {
-                    isDeprecated = isDeprecated || await result.Result.GetDeprecationMetadataAsync() != null;
+                    if (!isDeprecated)
+                    {
+                        var deprecationMetadata = await result.Result.GetDeprecationMetadataAsync();
+                        isDeprecated = isDeprecated || deprecationMetadata != null;
+                    }
                 }
             }