Add support for abstract Unix sockets #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszlig
force-pushed
the
abstract-sockets
branch
7 times, most recently
from
964023b
to
14d62fe
Compare
Adding abstract namespace sockets has been requested a long time ago[1] and while I also had a partial implementation laying around, it was also so ugly that I didn't want to merge it. The reason why it was ugly was that first of all, I added another "abstract" field to struct Rule and second, I used a boolean is_abstract all over the place to distinguish between socket_path and abstract. While in the end this resulted in a functional implementation, it also made the code messier and hard to extend. In the years passing since the aforementioned issue, I had several occasions where abstract sockets would have been useful, so today I decided to rewrite the ugly implementation mentioned above. The new implementation now simply abstracts away the socket_path field into a SocketPath type, which then either is marked Type::ABSTRACT or Type::FILESYSTEM. This has the advantage that we only need to know the details about SocketPath when we parse the rules and when we create the SockAddr, everything in between is just changing types from std::string to SocketPath. [1]: #8 Signed-off-by: aszlig <[email protected]> Closes: #8
aszlig
force-pushed
the
abstract-sockets
branch
from
14d62fe
to
a1b0a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract Unix domain sockets are a Linux extension, which allows to bind a socket to a name not bound to a particular file system path.
While I personally don't have a need for this, since I actually want to use file system paths in order to separate permissions, it does however make sense to support it for the sake of completeness.