-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait: support ptrace events for Linux #273
Conversation
Copying part of my comment on the previous discussion:
I'm going to hold off on this for a bit while I think about stuff related to #190. :-) |
☔ The latest upstream changes (presumably #362) made this pull request unmergeable. Please resolve the merge conflicts. |
Coming back to this, I'd be happier if the extra variant and methods were |
I was thinking about this again, and how to handle this in a way that isn't terrible across platforms. What would you think about adding another entry to the |
Sigh, I still haven't returned to this (haven't actually got a chance to touch Rust for a long time already). I understand that this can be frustrating, and also -- if anyone wants to continue this work please do so! I hope I can return to this someday... |
@abbradar this is not frustrating at all! And thanks for your contributions :-) |
Could you sketch out what you mean a tiny bit? |
Oh, I can do you one better! I actually wrote the patch because I wanted to use it for something, I just forgot to do anything with it. Here it is: Here's the code I wrote that uses it: I didn't actually try to make that code portable yet, but making it build should be straightforward. (Making it actually work right is probably harder). |
wait: Support ptrace events for Linux Adds new WaitStatus value `PtraceEvent`. Implementation of #273 that only affects Linux/Android.
Is this still relevant? If so, @abbradar would you be willing to update this patch? |
This was superseded by #438 You can see an example of using it here: https://github.com/luser/tracetree/blob/2dcde59a9b2bd8dd6343a147a6d09f5d4428068e/src/main.rs#L141 |
Okay, then I'm going to close this. Thanks, @luser. |
Part of #270 -- see abbradar@b2d3b4a for previous discussion.