Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with execvpe feature enabled #306

Closed
alex-gulyas opened this issue Mar 10, 2016 · 4 comments
Closed

Build fails with execvpe feature enabled #306

alex-gulyas opened this issue Mar 10, 2016 · 4 comments

Comments

@alex-gulyas
Copy link
Contributor

Build errors:

  • missing ffi module in unistd
  • use of undeclared type Error::Sys at src/unistd.rs:396
@felippemr
Copy link

Hi!
I'd like to help you with this issue, how can I get started?

@fiveop
Copy link
Contributor

fiveop commented Apr 21, 2016

This is already being tackled by #349 at the moment. Though, it is not clear whether that change will get into the tree in its current form. I'd still suggest starting with another bug. In particular the two other issues marked as good-first-bug provide lots of work.

@kamalmarhubi
Copy link
Member

Removed the labels for now.

@Susurrus
Copy link
Contributor

This is still a problem with the current release:

   Compiling nix v0.9.0-pre (file:///home/susurrus/Projects/nix)
error[E0433]: failed to resolve. Could not find `ffi` in `super`
    --> src/unistd.rs:1626:13
     |
1626 |             super::ffi::execvpe(filename.as_ptr(), args_p.as_ptr(), env_p.as_ptr())
     |             ^^^^^^^^^^^^^^^^^^^ Could not find `ffi` in `super`

error[E0433]: failed to resolve. Use of undeclared type or module `Error`
    --> src/unistd.rs:1629:13
     |
1629 |         Err(Error::Sys(Errno::last()))
     |             ^^^^^^^^^^ Use of undeclared type or module `Error`

error: aborting due to 2 previous errors

error: Could not compile `nix`.

To learn more, run the command again with --verbose.

I just tested all of the other features, and they all work fine at least.

This was referenced Jul 17, 2017
bors bot added a commit that referenced this issue Jul 18, 2017
681: Remove feature flags r=Susurrus

These are vestiges of the initial push to get this working on Rust 1.0. These feature flags are undocumented and so hard to discover (only learned about them today!), prevent functions being included that should be and this also affects documentation on docs.rs, and none of the features are tested in CI and the `execvpe` has been broken for forever.

The solution is to conditionally compile everything supported for a given platform and do away completely with the feature flags. The `execvpe` function is completely removed as it's not available for *nix platforms in libc and is already broken, so no loss removing it. We'll add it back once it's back in libc (rust-lang/libc#670).

Closes #98.
Closes #206.
Closes #306.
Closes #308.
bors bot added a commit that referenced this issue Jul 19, 2017
681: Remove feature flags r=Susurrus

These are vestiges of the initial push to get this working on Rust 1.0. These feature flags are undocumented and so hard to discover (only learned about them today!), prevent functions being included that should be and this also affects documentation on docs.rs, and none of the features are tested in CI and the `execvpe` has been broken for forever.

The solution is to conditionally compile everything supported for a given platform and do away completely with the feature flags. The `execvpe` function is completely removed as it's not available for *nix platforms in libc and is already broken, so no loss removing it. We'll add it back once it's back in libc (rust-lang/libc#670).

Closes #98.
Closes #206.
Closes #306.
Closes #308.
@bors bors bot closed this as completed in #681 Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants