Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional features are not build tested #308

Closed
alex-gulyas opened this issue Mar 10, 2016 · 2 comments
Closed

Optional features are not build tested #308

alex-gulyas opened this issue Mar 10, 2016 · 2 comments
Labels
A-infrastructure A-testing

Comments

@alex-gulyas
Copy link
Contributor

Currently none of the available optional features are built by Travis, therefore:
@kamalmarhubi
Copy link
Member

Thanks for bringing this up!

I think the right direction will be to break out the optional parts into separate crates. Eg, for signalfd we would want the function in nix-core but the iterator in nix-signalfd (or something like that).

This is still a little undecided. #190 is related.

@Susurrus
Copy link
Contributor

Susurrus commented Jun 5, 2017

Why don't we just enable the features in testing? I don't think this is a good rationale for splitting nix into several separate crates.

@Susurrus Susurrus mentioned this issue Jul 17, 2017
Merged
bors bot added a commit that referenced this issue Jul 18, 2017
@bors
Merge #681
e05fe97 
681: Remove feature flags r=Susurrus

These are vestiges of the initial push to get this working on Rust 1.0. These feature flags are undocumented and so hard to discover (only learned about them today!), prevent functions being included that should be and this also affects documentation on docs.rs, and none of the features are tested in CI and the `execvpe` has been broken for forever.

The solution is to conditionally compile everything supported for a given platform and do away completely with the feature flags. The `execvpe` function is completely removed as it's not available for *nix platforms in libc and is already broken, so no loss removing it. We'll add it back once it's back in libc (rust-lang/libc#670).

Closes #98.
Closes #206.
Closes #306.
Closes #308.
bors bot added a commit that referenced this issue Jul 19, 2017
@bors
Merge #681
07e6c2f 
681: Remove feature flags r=Susurrus

These are vestiges of the initial push to get this working on Rust 1.0. These feature flags are undocumented and so hard to discover (only learned about them today!), prevent functions being included that should be and this also affects documentation on docs.rs, and none of the features are tested in CI and the `execvpe` has been broken for forever.

The solution is to conditionally compile everything supported for a given platform and do away completely with the feature flags. The `execvpe` function is completely removed as it's not available for *nix platforms in libc and is already broken, so no loss removing it. We'll add it back once it's back in libc (rust-lang/libc#670).

Closes #98.
Closes #206.
Closes #306.
Closes #308.
@bors bors bot closed this as completed in #681 Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infrastructure A-testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kamalmarhubi @Susurrus @alex-gulyas