Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps tree-sitter Rust dependency to 0.23 #90

Closed
wants to merge 1 commit into from

Conversation

BekaValentine
Copy link
Contributor

This PR updates the tree-sitter version to 0.23 and makes corresponding changes to the rust bindings to make them uniform with current most up to date grammars for languages like C and C++.

The new lib.rs attempts to reproduce the behavior of @amaanq's corresponding changes elsewhere.

@BekaValentine
Copy link
Contributor Author

@cstrahan would it be possible to get approval for the workflow to run on this, and maybe get a review of it?

@scvalex
Copy link

scvalex commented Dec 15, 2024

I've tried this branch and it works for me. The new LANGUAGE member is really nice when interacting with the new tree-sitter-highlight API; without it, you have to add some ugly unsafe casts to get even the most basic functionality working.

@RaitoBezarius
Copy link
Member

@cstrahan Friendly ping.

@bobvanderlinden
Copy link

Maybe @zimbatm as well? The last PR that was merged was by him 😅

@Mic92
Copy link
Member

Mic92 commented Dec 19, 2024

@BekaValentine could you rebase?

@wetneb
Copy link

wetneb commented Jan 13, 2025

It would be great to have this merged and released! If that does not happen in the coming weeks, I am planning to fork this crate into an organization with a governance system to enable people to step in for maintenance tasks like this one.

@Mic92
Copy link
Member

Mic92 commented Jan 13, 2025

@BekaValentine I can merge this if you open a new pull request without merge conflicts. In nix-community we can also add new maintainers if the current ones are inactive.

@wetneb
Copy link

wetneb commented Jan 13, 2025

@Mic92 there you go: #124

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2025

Other PR has been merged.

@Mic92 Mic92 closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants