python-prefix-modules: init #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneSerge
commented
Nov 3, 2023
|
|
||
|
|
||
| def convert_to_packages(project_root, exclude_globs: List[str]): | ||
| project = Project(project_root) |
There was a problem hiding this comment.
I saw you were passing ropefolder=None elsewhere. I don't mind, I can do that as well for consistency
SomeoneSerge
force-pushed
the
feat/prefix-python-modules
branch
from
c551676 to
dce6c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/SomeoneSerge/pkgs/tree/3f07a5c33ca96b9cd828db9ad32bed9893076402/python-packages/by-name/pr/prefix-python-modules
Tested, somewhat, on https://github.com/SomeoneSerge/pkgs/blob/1dda035b977ac42b0573a3038efb49f5ad5469df/python-packages/by-name/ra/raft/package.nix#L59-L65 and https://github.com/SomeoneSerge/pkgs/blob/1dda035b977ac42b0573a3038efb49f5ad5469df/python-packages/by-name/om/omnimotion/package.nix#L52-L58.
The generated diffs look like this:
princeton-vl/RAFT@bc356c2
qianqianwang68/omnimotion@c45d860
facebookresearch/dino@6277288
The script has a bunch of
argparseoptions that I didn't write automated tests for... maybe I can rename them into--unsupported-$optionor--experimental-$option. Or I can just leave them as is