nixd/tools/nixd-attrset-eval: support completion for "builtins" #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic support for option completion on the worker process. This is the premise for doing this in LSP.
inclyc
commented
Nov 19, 2024
inclyc
commented
Nov 19, 2024
|
@inclyc did you request my review for something specific or more for a general review? |
Mic92
reviewed
Nov 19, 2024
A specific review for C++ nix IPC: This pull request introduces the ability to query Very appreciated if you can take a look :) |
|
It looks reasonable to me and similar to what the nix repl does for completing. However I would prefer if @roberth would have a look as well. |
roberth
reviewed
Nov 19, 2024
Co-authored-by: Jörg Thalheim <[email protected]>
Mic92
reviewed
Nov 20, 2024
| @@ -70,4 +70,9 @@ selectStringViews(nix::EvalState &State, nix::Value &V, | |||
| return selectSymbols(State, V, toSymbols(State.symbols, AttrPath)); | |||
| } | |||
|
|
|||
| /// \brief Get nix's `builtins` constant | |||
| inline nix::Value &getBuiltins(const nix::EvalState &State) { | |||
| return *State.baseEnv.values[0]; | |||
There was a problem hiding this comment.
I would do add a TODO now that this could use the proper api in the next nix version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic support for option completion on the worker process. This is the premise for doing this in LSP.
Link: #507