Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-manager: move tests into new test flake #6357

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

rycee
Copy link
Member

@rycee rycee commented Jan 24, 2025

Description

Having the tests available in the main Nix Flake introduces unnecessary evaluation for non-developer users and, worse, a dependency on the nmt library.

Fixes #6354

Checklist

  • Change is backwards compatible. It is not backwards compatible, but should only affect people that develop Home Manager.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

@rycee rycee self-assigned this Jan 24, 2025
@rycee rycee force-pushed the extract-tests-from-flake branch from 4e81f67 to 969eba6 Compare January 24, 2025 19:32
rycee added 2 commits January 24, 2025 22:31
Seems the nvim command sometimes fails with error code 1.
Having the tests available in the main Nix Flake introduces
unnecessary evaluation for non-developer users and, worse, a
dependency on the nmt library.

Fixes #6354
@rycee rycee force-pushed the extract-tests-from-flake branch from 969eba6 to 1b9fe46 Compare January 24, 2025 21:31
@rycee rycee merged commit 1b9fe46 into master Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Download of nmt fails because SourceHut has been DDoSed
1 participant