nodejs-package-lock-v3: Skip extraneous entries #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation was pagedjs-cli, which has the following lock file: https://github.com/pagedjs/pagedjs-cli/blob/d682e19ee5d14bfe07ad1726540e2423ede75a05/package-lock.json#L39 The explanation in https://docs.npmjs.com/cli/v7/commands/npm-prune/ is: > Extraneous packages are those present in the node_modules folder that > are not listed as any package's dependency list. > [..] > In normal operation, extraneous modules are pruned automatically, > so you'll only need this command with the --production flag. > However, in the real world, operation is not always "normal". > When crashes or mistakes happen, this command can help clean up any resulting garbage. Arguably it's the upstream package-lock.json that's broken, but OTOH, detecting this as an error in dream2nix would take as much code as just ignoring it, and just ignoring it is probably OK 99% of the time. At the very least it's more helpful than the previous error you would get, which is an error when it tries to access `entry.version`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation was pagedjs-cli, which has the following lock file: https://github.com/pagedjs/pagedjs-cli/blob/d682e19ee5d14bfe07ad1726540e2423ede75a05/package-lock.json#L39
The explanation in https://docs.npmjs.com/cli/v7/commands/npm-prune/ is:
Arguably it's the upstream package-lock.json that's broken, but OTOH, detecting this as an error in dream2nix would take as much code as just ignoring it,
and just ignoring it is probably OK 99% of the time.
At the very least it's more helpful than the previous error you would get, which is an error when it tries to access
entry.version.If the formatting of the code is not according to guidelines, please do say.