Get rid of dontStrip for Darwin as it's no longer needed

Fixed in NixOS/nixpkgs#255900
nix-community · Jun 16, 2024 · 0209f25 · 0209f25
1 parent dd8003b
commit 0209f25
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 10 deletions.
diff --git a/crate2nix/Cargo.nix b/crate2nix/Cargo.nix
@@ -3101,8 +3101,6 @@ rec {
  buildRustCrateForPkgsFunc pkgs
  (
  crateConfig // {
- # https://github.com/NixOS/nixpkgs/issues/218712
- dontStrip = stdenv.hostPlatform.isDarwin;
  src = crateConfig.src or (
  pkgs.fetchurl rec {
  name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";

diff --git a/crate2nix/templates/nix/crate2nix/default.nix b/crate2nix/templates/nix/crate2nix/default.nix
@@ -349,8 +349,6 @@ rec {
  buildRustCrateForPkgsFunc pkgs
  (
  crateConfig // {
- # https://github.com/NixOS/nixpkgs/issues/218712
- dontStrip = stdenv.hostPlatform.isDarwin;
  src = crateConfig.src or (
  pkgs.fetchurl rec {
  name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";

diff --git a/sample_projects/bin_with_git_submodule_dep/Cargo.nix b/sample_projects/bin_with_git_submodule_dep/Cargo.nix
@@ -1695,8 +1695,6 @@ rec {
  buildRustCrateForPkgsFunc pkgs
  (
  crateConfig // {
- # https://github.com/NixOS/nixpkgs/issues/218712
- dontStrip = stdenv.hostPlatform.isDarwin;
  src = crateConfig.src or (
  pkgs.fetchurl rec {
  name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";

diff --git a/sample_projects/codegen/Cargo.nix b/sample_projects/codegen/Cargo.nix
@@ -870,8 +870,6 @@ rec {
  buildRustCrateForPkgsFunc pkgs
  (
  crateConfig // {
- # https://github.com/NixOS/nixpkgs/issues/218712
- dontStrip = stdenv.hostPlatform.isDarwin;
  src = crateConfig.src or (
  pkgs.fetchurl rec {
  name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";

diff --git a/sample_projects/sub_dir_crates/Cargo.nix b/sample_projects/sub_dir_crates/Cargo.nix
@@ -479,8 +479,6 @@ rec {
  buildRustCrateForPkgsFunc pkgs
  (
  crateConfig // {
- # https://github.com/NixOS/nixpkgs/issues/218712
- dontStrip = stdenv.hostPlatform.isDarwin;
  src = crateConfig.src or (
  pkgs.fetchurl rec {
  name = "${crateConfig.crateName}-${crateConfig.version}.tar.gz";