Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve renamed option hardware.opengl -> hardware.graphics #503

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

getchoo
Copy link
Contributor

@getchoo getchoo commented Jun 26, 2024

As of NixOS/nixpkgs#320228, hardware.opengl was renamed to hardware.graphics, causing definitions of the former to trigger an evaluation warning on the current nixos-unstable channel. Aliases are applied conditionally for these new options to continue supporting 24.05

edit: fixes #498

Copy link

@malik-n malik-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
test seems to fail because of a temporary network issue?

@adminy
Copy link

adminy commented Jul 17, 2024

any updates on getting this merged? I keep getting this:

trace: warning: The option hardware.opengl.enable' defined in /nix/store/v5n25z2giklvxljzh0akxqzgjga73d87-source/modules/wsl-distro.nix' has been renamed to `hardware.graphics.enable'.

@SuperSandro2000 SuperSandro2000 changed the title chore: hardware.opengl -> hardware.graphics Resolve renamed option hardware.opengl -> hardware.graphics Jul 17, 2024
@SuperSandro2000 SuperSandro2000 merged commit 8ebede9 into nix-community:main Jul 17, 2024
24 checks passed
@getchoo getchoo deleted the hardware-graphics branch July 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option hardware.opengl.enable renamed in upstream
4 participants