Skip to content

Commit

Permalink
Remove commented lines of code
Browse files Browse the repository at this point in the history
  • Loading branch information
nivi-apple committed Nov 9, 2023
1 parent a9ff69c commit 56b73e2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ void DiagnosticLogsServer::HandleBDXResponse(CHIP_ERROR error)
}
else
{
SendErrorResponseAndReset(commandHandle, mRequestPath, StatusEnum::kNoLogs);
SendErrorResponse(commandHandle, mRequestPath, StatusEnum::kNoLogs);
}
}

Expand All @@ -147,17 +147,15 @@ void DiagnosticLogsServer::SetAsyncCommandHandleAndPath(CommandHandler * command
mRequestPath = commandPath;
}

void DiagnosticLogsServer::SendErrorResponseAndReset(chip::app::CommandHandler * commandHandler,
chip::app::ConcreteCommandPath path, StatusEnum status)
void DiagnosticLogsServer::SendErrorResponse(chip::app::CommandHandler * commandHandler, chip::app::ConcreteCommandPath path,
StatusEnum status)
{
Commands::RetrieveLogsResponse::Type response;
if (commandHandler != nullptr)
{
response.status = status;
commandHandler->AddResponse(path, response);
}
// mDiagnosticLogsBDXTransferHandler->Reset();
// delete(mDiagnosticLogsBDXTransferHandler);
}

#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class DiagnosticLogsServer

bool IsBDXProtocolRequested(TransferProtocolEnum requestedProtocol);

void SendErrorResponseAndReset(chip::app::CommandHandler * commandHandler, chip::app::ConcreteCommandPath path,
void SendErrorResponse(chip::app::CommandHandler * commandHandler, chip::app::ConcreteCommandPath path,
StatusEnum status);

#endif
Expand Down
2 changes: 0 additions & 2 deletions src/darwin/Framework/CHIP/MTRDiagnosticLogsTransferHandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,4 @@ class MTRDiagnosticLogsTransferHandler : public chip::bdx::Responder {

NSFileHandle * _Nullable mFileHandle;
std::function<void(bool)> mCallback;

bool mInitialized = false;
};

0 comments on commit 56b73e2

Please sign in to comment.