-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Example of VectorSource with a Third Party Tileset #1449
Open
tylergaw
wants to merge
2
commits into
nitaliano:master
Choose a base branch
from
tylergaw:tg-third-party-vector-tile-example
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import React from 'react'; | ||
import MapboxGL from '@mapbox/react-native-mapbox-gl'; | ||
|
||
import BaseExamplePropTypes from './common/BaseExamplePropTypes'; | ||
import Page from './common/Page'; | ||
|
||
import sheet from '../styles/sheet'; | ||
|
||
const styles = MapboxGL.StyleSheet.create({ | ||
line: { | ||
lineCap: "round", | ||
lineJoin: "round", | ||
lineOpacity: 0.6, | ||
lineColor: "rgb(53, 175, 109)", | ||
lineWidth: 2 | ||
}, | ||
}); | ||
|
||
const TILEJSON_URL = "https://s3.amazonaws.com/tgaw/tilejson.json"; | ||
|
||
// This example ported to React Native: | ||
// https://www.mapbox.com/mapbox-gl-js/example/third-party/ | ||
class ThirdPartyVectorTileSource extends React.PureComponent { | ||
static propTypes = { | ||
...BaseExamplePropTypes, | ||
}; | ||
|
||
render() { | ||
return ( | ||
<Page {...this.props}> | ||
<MapboxGL.MapView | ||
zoomLevel={12} | ||
centerCoordinate={[-87.622088, 41.878781]} | ||
styleURL="mapbox://styles/mapbox/light-v9" | ||
style={sheet.matchParent}> | ||
<MapboxGL.VectorSource | ||
id="customTileSourceExample" | ||
url={TILEJSON_URL}> | ||
<MapboxGL.LineLayer | ||
id="customTileSourceLine" | ||
sourceLayerID="mapillary-sequences" | ||
style={styles.line} | ||
/> | ||
</MapboxGL.VectorSource> | ||
</MapboxGL.MapView> | ||
</Page> | ||
); | ||
} | ||
} | ||
|
||
export default ThirdPartyVectorTileSource; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we'll want to leave this URL in place. That's an object in an S3 bucket that I own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea something we can do is just add a local tilejson file to the example app, so we can pull it off of the devices file system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sweet, didn't realize that could be a local file. I can update the example to use that instead. Also need to update my app to do the same.