Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for git localized messages issue, and also fixes "gc is already running" message #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denixx
Copy link

@denixx denixx commented May 15, 2019

No description provided.

@denixx
Copy link
Author

denixx commented May 15, 2019

Hi, @nirvdrum, let's continue with this new attempt...
#216

@jgubo-mct
Copy link

@nirvdrum Hi Kevin, why did you never merge this important fix for very large repositories? Should have made it to a new release instead of abandoning the project entirely :) Thanks @denixx for your work, helped me a lot!!!

@nirvdrum
Copy link
Owner

nirvdrum commented Jul 1, 2022

I've publicly stated that the project was stable and feature complete. This was further driven by the upstream work on git-svn having stagnated or stabilized as well.

Most PRs submitted here break compatibility or only work on one of the supported platforms. Nearly all the bugs reported really are issues upstream in git-svn. It's extremely time intensive verifying the PR does what it's supposed to.

To test this one, I'd need a system not using English. Forcing the en_US locale won't work on all systems, so that needs to be looked at. If the messages from git have changed, I have to look in which version and make sure that Ubuntu LTS works with that version.

We do have GitHub Actions available now. If you want to help set up a new CI system, I'd be happy to help and maybe we can get automated updates on PRs in terms of failed checks. Without that, I don't think you appreciate how much time it takes me to verify PRs, especially when the author hasn't provided the necessary background info.

Call it abandoned if you like, but to me the project met its stated design goals and works on a wide range of git versions and platforms. That said, if this really is a bug in svn2git and not some system environment issue or a bug in git-svn, then I'd be happy to merge it, pending the platform compatibility verification. Whenever I request this info, I get no help, just the expectation that I should do it in my apparently copious amount of free time.

@jgubo-mct
Copy link

Thanks a lot for your comprehensive answer. Yeah I totally understand that this fix is not only about the GC thread safety and ensuring the process finished, and testing the locale functionality takes more time to test.

And I haven't seen the project statement. No offense intended :)

@denixx
Copy link
Author

denixx commented Jul 1, 2022

Hi, Kevin!
May I write to you to try to get some help to have an experience with CI at GitHub for this project?
I would be glad to try it out two-three weeks later, just after I finish one course I am attending now.

@denixx
Copy link
Author

denixx commented Jul 1, 2022

@jgubo-mct You welcome, Johannes. I’m glad it is still useful. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants