-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adopt src/ layout and tox #458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 66.76% 74.35% +7.59%
==========================================
Files 31 25 -6
Lines 2079 1938 -141
Branches 205 240 +35
==========================================
+ Hits 1388 1441 +53
+ Misses 691 432 -259
- Partials 0 65 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
18c58e4
to
71b028b
Compare
@mgxd if you could have a look, I'd appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good - one question since it's not clear to me whether its present:
Do we still compare the tag version with the built version of the package? I found that check useful for catching mislabeled and dirty releases
The tests for the docker image are still there on Circle, which is where we've had actual problems AFAIR. Building the wheels for PyPI is generally less problematic, since you clone the whole repo and there isn't anything like |
0.17.0 (December 19, 2024) New feature release in the 0.17.x series. This release improves handling of datasets where T1w images are not the primary modality. It also supports the generation of fsLR meshes on the subject surface with the names: sub-<label>/anat/sub-<label>_hemi-<L|R>_space-fsLR_den-<label>_<surface>.surf.gii These are useful for plotting CIFTI results on subject anatomy. * FIX: Stop excluding FS minc_modify_header used during fallback registration (#453) * ENH: Output fsLR meshes on subject surfaces (#460) * ENH: Support spatial normalization to alternative modalities (#459) * ENH: Add `t2w_file` output to `TemplateFlowSelect` (#457) * MNT: Enable pre-release tests (#461) * MNT: Complete transition from flake8/black to ruff (#435) * MNT: Adopt src/ layout and tox (#458)
No description provided.