Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Remove much of the hardcoded T1w fields in favor of anat #433

Merged
merged 20 commits into from
Jul 26, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Apr 29, 2024

This is a supplemental PR to nipreps/nibabies#360 - since nibabies also relies on smriprep, but may be processing in T2w space, this PR generalize many of the workflows/nodes/fields to account for other anatomical references.

@mgxd mgxd force-pushed the enh/nibabies-fit-apply branch 2 times, most recently from 19049f4 to 3dd026f Compare July 25, 2024 17:04
@mgxd mgxd requested a review from effigies July 25, 2024 19:06
@mgxd
Copy link
Collaborator Author

mgxd commented Jul 25, 2024

@effigies This should be ready for review. I've tried to limit any breaking changes, but regardless this will need to be included in a new minor release

@effigies effigies marked this pull request as ready for review July 25, 2024 19:38
effigies added a commit to effigies/fmriprep that referenced this pull request Jul 26, 2024
@mgxd mgxd force-pushed the enh/nibabies-fit-apply branch from 4013bfe to 0e1b7cb Compare July 26, 2024 18:44
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.45%. Comparing base (7852cba) to head (4a8a782).

Files Patch % Lines
smriprep/workflows/outputs.py 96.15% 1 Missing ⚠️
smriprep/workflows/surfaces.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   66.37%   66.45%   +0.08%     
==========================================
  Files          30       30              
  Lines        2079     2087       +8     
  Branches      249      250       +1     
==========================================
+ Hits         1380     1387       +7     
- Misses        698      699       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some non-blocking comments.

@effigies effigies merged commit c361b3a into master Jul 26, 2024
17 checks passed
@effigies effigies deleted the enh/nibabies-fit-apply branch July 26, 2024 20:44
effigies added a commit to nipreps/fmriprep that referenced this pull request Jul 26, 2024
mgxd added a commit that referenced this pull request Aug 1, 2024
0.16.0 (July 31, 2024)

Start of the 0.16.x minor series.

This release decouples much of the hardcoded T1w behavior in favor of T1w/T2w options,
to allow easier integration with tools less reliant on a single anatomical scan.

* ENH: Use genericised "anat" input/output for TemplateDimensions (#443)
* ENH: Remove much of the hardcoded `T1w` fields in favor of `anat` (#433)
* RF: Load package data with acres (#448)
* RF: `space-fsaverage` to `sphere_reg` output files (#446)
* MNT: Unpin libitk 5.3 (ANTs 2.5.3 is built with 5.4) (#445)
* MNT: Clean up doc builds, environment, style checks (#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants