Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update surfaces with fsnative2t1w_xfm #384

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

effigies
Copy link
Member

@effigies effigies commented Nov 9, 2023

We weren't applying the fsnative2t1w_xfm to the surfaces when converting. Also updated the transform to nitransforms directly, and invert the fsnative2t1w mapping, since that mapping maps points in T1w space to fsnative and we need to go the other way.

Confirmed that surfaces now align. This is needed to get CIFTI resampling working correctly, as that depends on GIFTIs.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (05ae8c5) 58.65% compared to head (477063c) 58.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #384   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          26       26           
  Lines        1872     1872           
  Branches      238      238           
=======================================
  Hits         1098     1098           
  Misses        717      717           
  Partials       57       57           
Flag Coverage Δ
ds005 ∅ <ø> (∅)
ds054 46.79% <0.00%> (ø)
pytest 36.85% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
smriprep/workflows/surfaces.py 22.52% <ø> (ø)
smriprep/interfaces/surf.py 72.03% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit e370a73 into nipreps:next Nov 9, 2023
15 of 16 checks passed
@effigies effigies deleted the fix/transform_surfs branch November 9, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant