Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Clear registry consistently to avoid order dependency #464

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 3, 2024

With xdist in particular, tests having implicit or explicit order dependencies can cause problems. The main one for sdcflows is the fieldmap registry global state.

This PR auto-clears before and after every doctest and adds a fixture for test_fieldmaps to auto-clear before and after every test in that file. I think we should probably do it globally.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (1350d57) to head (aee2c92).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files          32       32           
  Lines        2816     2816           
  Branches      377      377           
=======================================
  Hits         2356     2356           
  Misses        390      390           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 18e5e95 into nipreps:master Oct 3, 2024
13 checks passed
@effigies effigies deleted the test/multiproc-safe branch October 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant