Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft MEDIC dynamic distortion correction method (second attempt) #438

Draft
wants to merge 50 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
50b5933
Add warpkit to dependencies.
tsalo May 4, 2024
ba9a65a
Write workflow.
tsalo May 4, 2024
49f9f90
Update medic.py
tsalo May 4, 2024
92342b5
Update medic.py
tsalo May 4, 2024
1468ca5
Add MEDIC test dataset.
tsalo May 4, 2024
27d0139
Add TotalReadoutTime field.
tsalo May 4, 2024
e3a5f99
Install Julia with micromamba, not Docker.
tsalo May 4, 2024
662542f
Aspirational doctest.
tsalo May 4, 2024
63aa532
Try wrangling MEDIC files.
tsalo May 7, 2024
5f84bd2
Merge remote-tracking branch 'upstream/master' into medic-whole
tsalo Jun 27, 2024
5b9814a
Merge branch 'master' into medic-whole
tsalo Sep 17, 2024
7750eaa
Merge remote-tracking branch 'upstream/master' into medic-whole
tsalo Oct 1, 2024
e63cd84
Fix connections.
tsalo Oct 1, 2024
d2569da
Merge branch 'master' into medic-whole
effigies Oct 4, 2024
b535b5f
Try @effigies' recommendation.
tsalo Oct 4, 2024
496fa10
Update sdcflows/utils/wrangler.py
tsalo Oct 4, 2024
79d1fb1
Search for phase to reduce false positives.
tsalo Oct 4, 2024
544ae7d
Address style issues and fix error.
tsalo Oct 4, 2024
8bef670
Update test_find_estimators.py
tsalo Oct 4, 2024
b164fa3
Update test_find_estimators.py
tsalo Oct 4, 2024
add5d9f
Drop test dataset in favor of dict.
tsalo Oct 12, 2024
a7b0f84
Update test_find_estimators.py
tsalo Oct 12, 2024
6fbb1cb
Drop old stuff.
tsalo Oct 12, 2024
6b7b416
Revert changes to failing test.
tsalo Oct 12, 2024
d2877b0
Update fieldmaps.py
tsalo Oct 12, 2024
8fa7c39
Just skip the failing test for now.
tsalo Oct 12, 2024
18b8e09
Fix.
tsalo Oct 12, 2024
2b9ff81
Update test_wrangler.py
tsalo Oct 12, 2024
084f199
Add B0Field fields to mock dataset.
tsalo Oct 13, 2024
9f2c089
Replace B0Field with IntendedFor.
tsalo Oct 13, 2024
bb660d2
Update wrangler.py
tsalo Oct 23, 2024
c2205e1
Add second session to test spec.
tsalo Oct 23, 2024
670ebc8
It needs a third session!
tsalo Oct 23, 2024
9c5fdd8
Alright maybe this'll work?
tsalo Oct 23, 2024
d7a59ee
Fix?
tsalo Oct 23, 2024
14e1ff1
Ignore long lines in test files.
tsalo Oct 23, 2024
1ba3e94
Fix long line.
tsalo Oct 23, 2024
45b256a
Change Julia version to make build work.
tsalo Dec 11, 2024
5d13425
Add test for new function.
tsalo Dec 12, 2024
3f48d93
Test collection on real data.
tsalo Dec 12, 2024
2815590
Fix check.
tsalo Dec 12, 2024
ee8c38a
Drop B0Field fields from fmaps.
tsalo Dec 12, 2024
f54533b
Update build-test-publish.yml
tsalo Dec 12, 2024
9c58221
Update wrangler.py
tsalo Dec 12, 2024
e205348
Fix key.
tsalo Dec 12, 2024
8f54fad
Draft medic workflow test.
tsalo Dec 12, 2024
25caaf3
Fix paths to metadata files.
tsalo Dec 12, 2024
54d92c4
Run ruff.
tsalo Dec 12, 2024
7c6cc93
Test both types of annotation.
tsalo Dec 12, 2024
085670d
Update wrangler.py
tsalo Dec 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions env.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ dependencies:
# Workflow dependencies: FSL (versions pinned in 6.0.6.2)
- fsl-fugue=2201.2
- fsl-topup=2203.1
# Workflow dependencies: Julia
- julia=1.9.4
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ dependencies = [
"scipy >= 1.8.1",
"templateflow",
"toml",
"warpkit == 0.1.1",
]
dynamic = ["version"]

Expand Down
8 changes: 6 additions & 2 deletions sdcflows/cli/tests/test_find_estimators.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,17 +133,21 @@
)
def test_cli_finder_wrapper(tmp_path, capsys, test_id, config, estimator_id):
"""Test the CLI with --dry-run."""
from nibabel.filebasedimages import ImageFileError

import sdcflows.config as sc

# Reload is necessary to clean-up the layout config between parameterized runs
reload(sc)

path = (tmp_path / test_id).absolute()
generate_bids_skeleton(path, config)
with pytest.raises(SystemExit) as wrapped_exit:
# This was set to raise a SystemExit, but was only raising an ImageFileError
with pytest.raises(ImageFileError) as wrapped_exit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably expecting valid headers in the images.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the changes I made to this test since other PRs don't seem to have an issue. I'm not sure why the problem is happening in this PR only, but I've tried to remove any extraneous changes in case those were causing the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can think is that maybe adding Julia and warpkit to the dependencies is affecting which versions of other dependencies are installed (e.g., a newer version of nibabel?).

cli_finder_wrapper([str(path), str(tmp_path / "out"), "participant", "--dry-run"])

assert wrapped_exit.value.code == 0
# ImageFileError has no code attribute, so we can't check the exit code
# assert wrapped_exit.value.code == 0
output = OUTPUT.format(path=path, estimator_id=estimator_id)
out, _ = capsys.readouterr()
assert out == output
Expand Down
1 change: 1 addition & 0 deletions sdcflows/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def doctest_fixture(doctest_namespace, request):
dsA_dir=data_dir / "dsA",
dsB_dir=data_dir / "dsB",
dsC_dir=data_dir / "dsC",
dsD_dir=data_dir / "dsD",
)
doctest_namespace.update((key, Path(val.root)) for key, val in layouts.items())

Expand Down
12 changes: 9 additions & 3 deletions sdcflows/fieldmaps.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
PHASEDIFF = auto()
MAPPED = auto()
ANAT = auto()
MEDIC = auto()


MODALITIES = {
Expand All @@ -67,6 +68,7 @@
"sbref": EstimatorType.PEPOLAR,
"T1w": EstimatorType.ANAT,
"T2w": EstimatorType.ANAT,
"medic": EstimatorType.MEDIC,
}


Expand Down Expand Up @@ -313,16 +315,20 @@

# Fieldmap option 1: actual field-mapping sequences
fmap_types = suffix_set.intersection(
("fieldmap", "phasediff", "phase1", "phase2")
("fieldmap", "phasediff", "phase1", "phase2", "bold")
)
if len(fmap_types) > 1 and fmap_types - set(("phase1", "phase2")):
raise TypeError(f"Incompatible suffices found: <{','.join(fmap_types)}>.")
raise TypeError(f"Incompatible suffixes found: <{','.join(fmap_types)}>.")

Check warning on line 321 in sdcflows/fieldmaps.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/fieldmaps.py#L321

Added line #L321 was not covered by tests

# Check for MEDIC
if "part-mag" in self.sources[0].path:
fmap_types = set(list(fmap_types) + ["medic"])

Check warning on line 325 in sdcflows/fieldmaps.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/fieldmaps.py#L325

Added line #L325 was not covered by tests

if fmap_types:
sources = sorted(
f.path
for f in self.sources
if f.suffix in ("fieldmap", "phasediff", "phase1", "phase2")
if f.suffix in ("fieldmap", "phasediff", "phase1", "phase2", "bold")
)

# Automagically add the corresponding phase2 file if missing as argument
Expand Down
114 changes: 114 additions & 0 deletions sdcflows/interfaces/fmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
from nipype import logging
from nipype.interfaces.base import (
BaseInterfaceInputSpec,
CommandLineInputSpec,
CommandLine,
TraitedSpec,
File,
traits,
Expand Down Expand Up @@ -62,6 +64,27 @@
return runtime


class _PhaseMap2rads2InputSpec(BaseInterfaceInputSpec):
in_file = File(exists=True, mandatory=True, desc="input (wrapped) phase map")


class _PhaseMap2rads2OutputSpec(TraitedSpec):
out_file = File(desc="the phase map in the range -3.14 - 3.14")


class PhaseMap2rads2(SimpleInterface):
"""Convert a phase map given in a.u. (e.g., 0-4096) to radians."""

input_spec = _PhaseMap2rads2InputSpec
output_spec = _PhaseMap2rads2OutputSpec

def _run_interface(self, runtime):
from ..utils.phasemanip import au2rads2

Check warning on line 82 in sdcflows/interfaces/fmap.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/interfaces/fmap.py#L82

Added line #L82 was not covered by tests

self._results["out_file"] = au2rads2(self.inputs.in_file, newpath=runtime.cwd)
return runtime

Check warning on line 85 in sdcflows/interfaces/fmap.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/interfaces/fmap.py#L84-L85

Added lines #L84 - L85 were not covered by tests


class _SubtractPhasesInputSpec(BaseInterfaceInputSpec):
in_phases = traits.List(File(exists=True), min=1, max=2, desc="input phase maps")
in_meta = traits.List(
Expand Down Expand Up @@ -390,3 +413,94 @@
f"{img1.get_filename()} {''.join(nb.aff2axcodes(img1.affine))}, "
f"{img2.get_filename()} {''.join(nb.aff2axcodes(img2.affine))}"
)


class _MEDICInputSpec(CommandLineInputSpec):
mag_files = traits.List(
File(exists=True),
argstr="--magnitude %s",
mandatory=True,
minlen=2,
desc="Magnitude image(s) to verify registration",
)
phase_files = traits.List(
File(exists=True),
argstr="--phase %s",
mandatory=True,
minlen=2,
desc="Phase image(s) to verify registration",
)
metadata = traits.List(
File(exists=True),
argstr="--metadata %s",
mandatory=True,
minlen=2,
desc="Metadata corresponding to the inputs",
)
prefix = traits.Str(
"medic",
argstr="--out_prefix %s",
usedefault=True,
desc="Prefix for output files",
)
noise_frames = traits.Int(
0,
argstr="--noiseframes %d",
usedefault=True,
desc="Number of noise frames to remove",
)
n_cpus = traits.Int(
4,
argstr="--n_cpus %d",
usedefault=True,
desc="Number of CPUs to use",
)
debug = traits.Bool(
False,
argstr="--debug",
usedefault=True,
desc="Enable debugging output",
)
wrap_limit = traits.Bool(
False,
argstr="--wrap_limit",
usedefault=True,
desc="Turns off some heuristics for phase unwrapping",
)


class _MEDICOutputSpec(TraitedSpec):
native_field_map = File(
exists=True,
desc="4D ative (distorted) space field map in Hertz",
)
displacement_map = File(
exists=True,
desc="4D displacement map in millimeters",
)
field_map = File(
exists=True,
desc="4D undistorted field map in Hertz",
)


class MEDIC(CommandLine):
"""Run MEDIC."""

_cmd = "medic"
input_spec = _MEDICInputSpec
output_spec = _MEDICOutputSpec

def _list_outputs(self):
outputs = self._outputs().get()
out_dir = os.getcwd()
outputs['native_field_map'] = os.path.join(

Check warning on line 497 in sdcflows/interfaces/fmap.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/interfaces/fmap.py#L495-L497

Added lines #L495 - L497 were not covered by tests
out_dir,
f'{self.inputs.prefix}_fieldmaps_native.nii',
)
outputs['displacement_map'] = os.path.join(

Check warning on line 501 in sdcflows/interfaces/fmap.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/interfaces/fmap.py#L501

Added line #L501 was not covered by tests
out_dir,
f'{self.inputs.prefix}_displacementmaps.nii',
)
outputs['field_map'] = os.path.join(out_dir, f'{self.inputs.prefix}_fieldmaps.nii')
return outputs

Check warning on line 506 in sdcflows/interfaces/fmap.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/interfaces/fmap.py#L505-L506

Added lines #L505 - L506 were not covered by tests
11 changes: 11 additions & 0 deletions sdcflows/tests/data/dsD/dataset_description.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"Name": "Test Dataset D for MEDIC, only empty files",
"BIDSVersion": "",
"License": "CC0",
"Authors": ["Salo T."],
"Acknowledgements": "",
"HowToAcknowledge": "",
"Funding": "",
"ReferencesAndLinks": [""],
"DatasetDOI": ""
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
{
"B0FieldIdentifier": "medic",
"B0FieldSource": "medic",
"EchoTime": 0.0142,
"FlipAngle": 68,
"ImageType": [
"ORIGINAL",
"PRIMARY",
"M",
"MB",
"TE2",
"ND",
"NORM",
"MOSAIC"
],
"PhaseEncodingDirection": "j",
"RepetitionTime": 1.761,
"SliceTiming": [
0,
0.725,
1.45,
0.435,
1.16,
0.145,
0.87,
1.595,
0.58,
1.305,
0.29,
1.015,
0,
0.725,
1.45,
0.435,
1.16,
0.145,
0.87,
1.595,
0.58,
1.305,
0.29,
1.015,
0,
0.725,
1.45,
0.435,
1.16,
0.145,
0.87,
1.595,
0.58,
1.305,
0.29,
1.015,
0,
0.725,
1.45,
0.435,
1.16,
0.145,
0.87,
1.595,
0.58,
1.305,
0.29,
1.015,
0,
0.725,
1.45,
0.435,
1.16,
0.145,
0.87,
1.595,
0.58,
1.305,
0.29,
1.015,
0,
0.725,
1.45,
0.435,
1.16,
0.145,
0.87,
1.595,
0.58,
1.305,
0.29,
1.015
],
"SpacingBetweenSlices": 2,
"TotalReadoutTime": 0.03
}
Loading
Loading