-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft MEDIC dynamic distortion correction method (second attempt) #438
Draft
tsalo
wants to merge
50
commits into
nipreps:master
Choose a base branch
from
tsalo:medic-whole
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 20 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
50b5933
Add warpkit to dependencies.
tsalo ba9a65a
Write workflow.
tsalo 49f9f90
Update medic.py
tsalo 92342b5
Update medic.py
tsalo 1468ca5
Add MEDIC test dataset.
tsalo 27d0139
Add TotalReadoutTime field.
tsalo e3a5f99
Install Julia with micromamba, not Docker.
tsalo 662542f
Aspirational doctest.
tsalo 63aa532
Try wrangling MEDIC files.
tsalo 5f84bd2
Merge remote-tracking branch 'upstream/master' into medic-whole
tsalo 5b9814a
Merge branch 'master' into medic-whole
tsalo 7750eaa
Merge remote-tracking branch 'upstream/master' into medic-whole
tsalo e63cd84
Fix connections.
tsalo d2569da
Merge branch 'master' into medic-whole
effigies b535b5f
Try @effigies' recommendation.
tsalo 496fa10
Update sdcflows/utils/wrangler.py
tsalo 79d1fb1
Search for phase to reduce false positives.
tsalo 544ae7d
Address style issues and fix error.
tsalo 8bef670
Update test_find_estimators.py
tsalo b164fa3
Update test_find_estimators.py
tsalo add5d9f
Drop test dataset in favor of dict.
tsalo a7b0f84
Update test_find_estimators.py
tsalo 6fbb1cb
Drop old stuff.
tsalo 6b7b416
Revert changes to failing test.
tsalo d2877b0
Update fieldmaps.py
tsalo 8fa7c39
Just skip the failing test for now.
tsalo 18b8e09
Fix.
tsalo 2b9ff81
Update test_wrangler.py
tsalo 084f199
Add B0Field fields to mock dataset.
tsalo 9f2c089
Replace B0Field with IntendedFor.
tsalo bb660d2
Update wrangler.py
tsalo c2205e1
Add second session to test spec.
tsalo 670ebc8
It needs a third session!
tsalo 9c5fdd8
Alright maybe this'll work?
tsalo d7a59ee
Fix?
tsalo 14e1ff1
Ignore long lines in test files.
tsalo 1ba3e94
Fix long line.
tsalo 45b256a
Change Julia version to make build work.
tsalo 5d13425
Add test for new function.
tsalo 3f48d93
Test collection on real data.
tsalo 2815590
Fix check.
tsalo ee8c38a
Drop B0Field fields from fmaps.
tsalo f54533b
Update build-test-publish.yml
tsalo 9c58221
Update wrangler.py
tsalo e205348
Fix key.
tsalo 8f54fad
Draft medic workflow test.
tsalo 25caaf3
Fix paths to metadata files.
tsalo 54d92c4
Run ruff.
tsalo 7c6cc93
Test both types of annotation.
tsalo 085670d
Update wrangler.py
tsalo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"Name": "Test Dataset D for MEDIC, only empty files", | ||
"BIDSVersion": "", | ||
"License": "CC0", | ||
"Authors": ["Salo T."], | ||
"Acknowledgements": "", | ||
"HowToAcknowledge": "", | ||
"Funding": "", | ||
"ReferencesAndLinks": [""], | ||
"DatasetDOI": "" | ||
} |
94 changes: 94 additions & 0 deletions
94
sdcflows/tests/data/dsD/sub-01/func/sub-01_task-rest_echo-1_part-mag_bold.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
{ | ||
"B0FieldIdentifier": "medic", | ||
"B0FieldSource": "medic", | ||
"EchoTime": 0.0142, | ||
"FlipAngle": 68, | ||
"ImageType": [ | ||
"ORIGINAL", | ||
"PRIMARY", | ||
"M", | ||
"MB", | ||
"TE2", | ||
"ND", | ||
"NORM", | ||
"MOSAIC" | ||
], | ||
"PhaseEncodingDirection": "j", | ||
"RepetitionTime": 1.761, | ||
"SliceTiming": [ | ||
0, | ||
0.725, | ||
1.45, | ||
0.435, | ||
1.16, | ||
0.145, | ||
0.87, | ||
1.595, | ||
0.58, | ||
1.305, | ||
0.29, | ||
1.015, | ||
0, | ||
0.725, | ||
1.45, | ||
0.435, | ||
1.16, | ||
0.145, | ||
0.87, | ||
1.595, | ||
0.58, | ||
1.305, | ||
0.29, | ||
1.015, | ||
0, | ||
0.725, | ||
1.45, | ||
0.435, | ||
1.16, | ||
0.145, | ||
0.87, | ||
1.595, | ||
0.58, | ||
1.305, | ||
0.29, | ||
1.015, | ||
0, | ||
0.725, | ||
1.45, | ||
0.435, | ||
1.16, | ||
0.145, | ||
0.87, | ||
1.595, | ||
0.58, | ||
1.305, | ||
0.29, | ||
1.015, | ||
0, | ||
0.725, | ||
1.45, | ||
0.435, | ||
1.16, | ||
0.145, | ||
0.87, | ||
1.595, | ||
0.58, | ||
1.305, | ||
0.29, | ||
1.015, | ||
0, | ||
0.725, | ||
1.45, | ||
0.435, | ||
1.16, | ||
0.145, | ||
0.87, | ||
1.595, | ||
0.58, | ||
1.305, | ||
0.29, | ||
1.015 | ||
], | ||
"SpacingBetweenSlices": 2, | ||
"TotalReadoutTime": 0.03 | ||
} |
Empty file.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably expecting valid headers in the images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the changes I made to this test since other PRs don't seem to have an issue. I'm not sure why the problem is happening in this PR only, but I've tried to remove any extraneous changes in case those were causing the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I can think is that maybe adding
Julia
andwarpkit
to the dependencies is affecting which versions of other dependencies are installed (e.g., a newer version of nibabel?).