Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft MEDIC dynamic distortion correction method (second attempt) #438

Draft
wants to merge 50 commits into
base: master
Choose a base branch
from

Try @effigies' recommendation.

b535b5f
Select commit
Loading
Failed to load commit list.
Draft

Draft MEDIC dynamic distortion correction method (second attempt) #438

Try @effigies' recommendation.
b535b5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 4, 2024 in 0s

40.28% (-43.47%) compared to 656a51d

View this Pull Request on Codecov

40.28% (-43.47%) compared to 656a51d

Details

Codecov Report

Attention: Patch coverage is 37.23404% with 59 lines in your changes missing coverage. Please review.

Project coverage is 40.28%. Comparing base (656a51d) to head (b535b5f).

Files with missing lines Patch % Lines
sdcflows/workflows/fit/medic.py 28.00% 18 Missing ⚠️
sdcflows/utils/wrangler.py 0.00% 15 Missing ⚠️
sdcflows/utils/phasemanip.py 6.66% 14 Missing ⚠️
sdcflows/interfaces/fmap.py 74.28% 9 Missing ⚠️
sdcflows/fieldmaps.py 25.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (656a51d) and HEAD (b535b5f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (656a51d) HEAD (b535b5f)
6 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #438       +/-   ##
===========================================
- Coverage   83.75%   40.28%   -43.47%     
===========================================
  Files          32       33        +1     
  Lines        2831     2924       +93     
  Branches      381      386        +5     
===========================================
- Hits         2371     1178     -1193     
- Misses        390     1668     +1278     
- Partials       70       78        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.