-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Allow unwarp to apply only to references #385
Conversation
This is intended to reduce the footprint of the EPI fit workflow. The corrected reference image will be used for T1w coregistration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 81.99% 81.97% -0.03%
==========================================
Files 26 26
Lines 2271 2274 +3
Branches 281 282 +1
==========================================
+ Hits 1862 1864 +2
Misses 362 362
- Partials 47 48 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the idea that a new reference is generated with the unwarped data, but that is probably is good overall, as the programmer will be required to generate the new reference explicitly with the undistorted data, if they don't want to directly use the unwarped reference.
Looks great to me :)
I came back to check one thing - the |
Sorry, you mean distorted_ref should be averaged, in case it has multiple time points? I thought by the time we got to this, sbrefs had already been merged to a single volume. |
If that is the expectation, we should make it very clear that it has been averaged. However, resample would handle that just fine, allowing less data munging before correcting. |
8b385a9
to
661ca8f
Compare
Closing in favor of #346. We will probably want to make averaging and brain extraction optional in a future PR, to avoid duplicating effort when only a timeseries is needed. |
This PR adds a
ref_only
mode toinit_unwarp_wf
that allows the same workflow to be used only on reference volumes.This also changes the output reference volume to be derived from the input reference volume, rather than the average of the corrected time series.