ENH: Function to calculate reference grids aligned with the coefficients #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
2 times, most recently
from
d1c5fd2 to
2b9eaef
Compare
|
A test should come shortly - cleaning up some of the code of ChatGPT :D |
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
2 times, most recently
from
0b42d2e to
acf0f46
Compare
effigies
reviewed
Apr 27, 2023
effigies
reviewed
Apr 27, 2023
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
from
acf0f46 to
562ff6b
Compare
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
from
562ff6b to
0597421
Compare
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
from
0597421 to
ebc926d
Compare
Co-authored-by: Chris Markiewicz <[email protected]>
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
from
b8b7c53 to
ac80266
Compare
after long time scratching my head, it seems mango does not always interpret orientation correctly. freeview seems to do so though.
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
from
2f705e4 to
f03d54a
Compare
|
While debugging this, I've found:
|
|
@effigies this is now ready. I submitted it without the draft marking because I thought the initial version was more mature and testing was going to be easier, which didn't happen. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 83.08% 83.27% +0.18%
==========================================
Files 25 25
Lines 2123 2147 +24
Branches 258 260 +2
==========================================
+ Hits 1764 1788 +24
Misses 313 313
Partials 46 46
☔ View full report in Codecov by Sentry. |
effigies
reviewed
Apr 28, 2023
mgxd
reviewed
Apr 28, 2023
Co-authored-by: Mathias Goncalves <[email protected]> Co-authored-by: Chris Markiewicz <[email protected]>
oesteban
force-pushed
the
enh/calculate-bspline-dense-reference
branch
from
6fc63d4 to
f01cee1
Compare
oesteban
added a commit
that referenced
this pull request
May 2, 2023
oesteban
added a commit
that referenced
this pull request
Jun 30, 2023
oesteban
added a commit
that referenced
this pull request
Jul 7, 2023
oesteban
added a commit
that referenced
this pull request
Jul 11, 2023
oesteban
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off from #346, to focus only on this particular task, which is probably the most complicated aspect of the refactor (or the one we definitely want to get right).