Skip to content

Commit

Permalink
maint: ensure nothing is imported/remains from MRIQC
Browse files Browse the repository at this point in the history
  • Loading branch information
oesteban committed Dec 4, 2023
1 parent 07887e0 commit a77775f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ doc = [
"nbsphinx",
"nibabel",
"nipype >= 1.5.1",
"niworkflows >= 1.7.0",
"niworkflows @ git+https://github.com/nipreps/niworkflows.git@master",
"numpy",
"packaging",
"pandoc",
Expand Down
10 changes: 5 additions & 5 deletions sdcflows/cli/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ def main(argv=None):
parse_args(argv)

if config.execution.pdb:
from mriqc.utils.debug import setup_exceptionhook
from niworkflows.utils.debug import setup_exceptionhook

Check warning on line 42 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L42

Added line #L42 was not covered by tests

setup_exceptionhook()
config.nipype.plugin = "Linear"

Check warning on line 45 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L44-L45

Added lines #L44 - L45 were not covered by tests

# CRITICAL Save the config to a file. This is necessary because the execution graph
# is built as a separate process to keep the memory footprint low. The most
# straightforward way to communicate with the child process is via the filesystem.
# The config file name needs to be unique, otherwise multiple mriqc instances
# The config file name needs to be unique, otherwise multiple sdcflows instances
# will create write conflicts.
config_file = mktemp(
dir=config.execution.work_dir, prefix=".sdcflows.", suffix=".toml"
Expand Down Expand Up @@ -133,7 +133,7 @@ def main(argv=None):

# CRITICAL Load the config from the file. This is necessary because the ``build_workflow``
# function executed constrained in a process may change the config (and thus the global
# state of MRIQC).
# state of SDCFlows).
config.load(config_file)

Check warning on line 137 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L137

Added line #L137 was not covered by tests

exitcode = exitcode or (sdcflows_wf is None) * os.EX_SOFTWARE

Check warning on line 139 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L139

Added line #L139 was not covered by tests
Expand Down Expand Up @@ -164,10 +164,10 @@ def main(argv=None):

# Clean up master process before running workflow, which may create forks
gc.collect()

Check warning on line 166 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L166

Added line #L166 was not covered by tests
# run MRIQC
# run SDCFlows
_plugin = config.nipype.get_plugin()

Check warning on line 168 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L168

Added line #L168 was not covered by tests
if _pool:
from mriqc.engine.plugin import MultiProcPlugin
from niworkflows.engine.plugin import MultiProcPlugin

Check warning on line 170 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L170

Added line #L170 was not covered by tests

_plugin = {

Check warning on line 172 in sdcflows/cli/main.py

View check run for this annotation

Codecov / codecov/patch

sdcflows/cli/main.py#L172

Added line #L172 was not covered by tests
"plugin": MultiProcPlugin(
Expand Down
2 changes: 1 addition & 1 deletion sdcflows/cli/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def _bids_filter(value):
"--notrack",
action="store_true",
help="Opt-out of sending tracking information of this run to the NiPreps developers. This"
" information helps to improve MRIQC and provides an indicator of real world usage "
" information helps to improve SDCFlows and provides an indicator of real world usage "
" crucial for obtaining funding.",
)

Expand Down

0 comments on commit a77775f

Please sign in to comment.