Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Address some reliability issues of the functional masking workflow #711

Closed
wants to merge 7 commits into from

Conversation

oesteban
Copy link
Member

Replaces: #707.
Addresses: nipreps/fmriprep#2731.

@mgxd
Copy link
Contributor

mgxd commented Apr 19, 2022

@oesteban we disabled the masks/ regression test (see #671) - perhaps it would be good to re-add and see if this improvement addresses the intermittent issues we were experiencing

@@ -118,32 +118,6 @@ def _run_interface(self, runtime):
return runtime


class _BinaryDilationInputSpec(BaseInterfaceInputSpec):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with the merge..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:S

@oesteban
Copy link
Member Author

Ha! Yes, I think that makes sense.

@effigies
Copy link
Member

effigies commented Apr 20, 2022

@oesteban I pushed the pre-rebase version (97be9e5) from #707 to https://github.com/nipreps/niworkflows/compare/restore-707 if you just want to use that.

@oesteban
Copy link
Member Author

Okay, the merge doesn't seem great :(

@codecov-commenter
Copy link

Codecov Report

Merging #711 (97be9e5) into master (e1f4267) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 97be9e5 differs from pull request most recent head 0509a28. Consider uploading reports for the commit 0509a28 to get more accurate results

@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   49.18%   49.19%           
=======================================
  Files          49       49           
  Lines        5866     5865    -1     
  Branches      837      837           
=======================================
  Hits         2885     2885           
+ Misses       2872     2871    -1     
  Partials      109      109           
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests 49.19% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/func/util.py 18.18% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f4267...0509a28. Read the comment docs.

@mgxd mgxd closed this Apr 20, 2022
@effigies effigies deleted the masks/robustify-workflow branch January 27, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants