ENH: Make type hinting compatible with Python 3.9 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
FixPython39TypeHinting
branch
2 times, most recently
from
c022f91 to
807ff78
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 64.22% 65.47% +1.25%
==========================================
Files 25 25
Lines 2661 2662 +1
Branches 365 418 +53
==========================================
+ Hits 1709 1743 +34
+ Misses 838 807 -31
+ Partials 114 112 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jhlegarreta
force-pushed
the
FixPython39TypeHinting
branch
5 times, most recently
from
f4c99b7 to
f080d32
Compare
Make type hinting compatible with Python 3.9: use `Union` instead of the pipe operator `|` to support type hints in Python 3.9. The pipe operator was overloaded for writing union types starting Python 3.10: https://peps.python.org/pep-0604/ https://docs.python.org/3.9/library/typing.html https://docs.python.org/3.10/library/typing.html Inadvertently let go through in commits 44d0ff6 and 8c18471.
jhlegarreta
force-pushed
the
FixPython39TypeHinting
branch
from
f080d32 to
41ed328
Compare
|
Sorry Chris, my bad, I did not pay due attention to the failures in PR #147. |
|
Looks good! I started on this locally, but didn't finish and push. Thanks for cleaning it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make type hinting compatible with Python 3.9: use
Unioninstead of the pipe operator|to support type hints in Python 3.9. The pipe operator was overloaded for writing union types starting Python 3.10: https://peps.python.org/pep-0604/https://docs.python.org/3.9/library/typing.html
https://docs.python.org/3.10/library/typing.html
Inadvertently let go through in commits 44d0ff6 and 8c18471.