Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): Configure and run mypy checks in CI #146

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

effigies
Copy link
Member

As a relatively small package, this seemed like a good place to start. As we add type annotations, mypy will ensure that we do it correctly.

cc @jhlegarreta

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (d923a42) to head (cccd528).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   65.10%   65.32%   +0.22%     
==========================================
  Files          25       25              
  Lines        2642     2642              
  Branches      415      415              
==========================================
+ Hits         1720     1726       +6     
+ Misses        811      807       -4     
+ Partials      111      109       -2     
Flag Coverage Δ
unittests 64.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @effigies. I have only one inline question.

I see checks passing 🎉.

pyproject.toml Show resolved Hide resolved
@jhlegarreta jhlegarreta merged commit f0690a1 into nipreps:main Dec 19, 2024
16 checks passed
@effigies effigies deleted the mypy branch December 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants