Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Higher-level carpetplot tooling for DWI #119

Merged
merged 17 commits into from
Jul 2, 2024

Conversation

teresamg
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.95%. Comparing base (34bf28c) to head (da0e98f).
Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
nireports/reportlets/modality/dwi.py 78.26% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   59.19%   59.95%   +0.75%     
==========================================
  Files          20       20              
  Lines        2174     2220      +46     
  Branches      383      395      +12     
==========================================
+ Hits         1287     1331      +44     
+ Misses        794      793       -1     
- Partials       93       96       +3     
Flag Coverage Δ
unittests 59.80% <78.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

@teresamg Please git pull before continuing work on this PR.

@jhlegarreta
Copy link
Collaborator

Cross referencing nipreps/eddymotion#192 (comment). Note that the get_segment_labels function should probably be carried over to here as well.

@oesteban
Copy link
Member

oesteban commented Jun 3, 2024

@teresamg @arokem what's the status of this? can we try to merge it before tomorrow's meeting? I am happy to push tonight/tomorrow morning -- let me know how I can help.

@teresamg
Copy link
Contributor Author

teresamg commented Jun 4, 2024

Right now I think it just needs thorough testing with dwi data + bvals + segmentation... there wasn't much in the tests/data folder but what's there did run without breaking

@oesteban oesteban force-pushed the plot_carpet branch 3 times, most recently from ea3b850 to 084ddb7 Compare July 1, 2024 13:29
@oesteban oesteban changed the title WIP: Adds higher level carpot_plot function ENH: Adds higher-level carpetplot tooling for DWI Jul 2, 2024
@oesteban oesteban changed the title ENH: Adds higher-level carpetplot tooling for DWI ENH: Higher-level carpetplot tooling for DWI Jul 2, 2024
@oesteban oesteban marked this pull request as ready for review July 2, 2024 10:41
@oesteban oesteban merged commit dbdb89f into nipreps:main Jul 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants