ENH: Fix nibabel image type checking errors
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
FixNiBabelLoadTypeCheckingErrors
branch
3 times, most recently
from
9e4a6d9 to
29376ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 65.84% 65.74% -0.10%
==========================================
Files 18 19 +1
Lines 931 940 +9
Branches 119 120 +1
==========================================
+ Hits 613 618 +5
- Misses 274 278 +4
Partials 44 44 ☔ View full report in Codecov by Sentry. |
jhlegarreta
force-pushed
the
FixNiBabelLoadTypeCheckingErrors
branch
2 times, most recently
from
af97c26 to
e0a3350
Compare
Fix `nibabel` image type checking errors: add a `load_api` utils function to provide the appropriate type when loading a `NiBabel` N-dimensional image. Solution drawn from: nipreps/nireports@44d0ff6 Fixes: ``` scripts/dwi_gp_estimation_signal_plot.py:113: error: "FileBasedImage" has no attribute "get_fdata" [attr-defined] scripts/dwi_gp_estimation_signal_plot.py:114: error: "FileBasedImage" has no attribute "get_fdata" [attr-defined] ``` and ``` scripts/optimize_registration.py:173: error: Argument 1 to "displacements_within_mask" has incompatible type "FileBasedImage"; expected "SpatialImage" [arg-type] ``` raised for example in: https://github.com/nipreps/nifreeze/actions/runs/12437972140/job/34728973936#step:8:63 and https://github.com/nipreps/nifreeze/actions/runs/12437972140/job/34728973936#step:8:142 Rename the previously existing `utils.py` file to `iterators.py` and move it to the newly created `utils` module to avoid package name clashes. Change the related import statements accordingly.
effigies
force-pushed
the
FixNiBabelLoadTypeCheckingErrors
branch
from
e0a3350 to
adb9329
Compare
effigies
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
nibabelimage type checking errors: add aload_apiutils function to provide the appropriate type when loading aNiBabelN-dimensional image.Solution drawn from:
nipreps/nireports@44d0ff6
Fixes:
and
raised for example in:
https://github.com/nipreps/nifreeze/actions/runs/12437972140/job/34728973936#step:8:63 and
https://github.com/nipreps/nifreeze/actions/runs/12437972140/job/34728973936#step:8:142
Rename the previously existing
utils.pyfile toiterators.pyand move it to the newly createdutilsmodule to avoid package name clashes. Change the related import statements accordingly.