ENH: Use keyword arguments when calling DIPY keyword arg functions #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
CallDIPYFuncsWithKeywordArgs
branch
2 times, most recently
from
b6c01fe to
ae3c539
Compare
Pass parameters as keyword arguments when calling DIPY functions and methods that have keyword arguments: DIPY has transitioned to keyword-only arguments for these starting version 1.10.0 (released Dec 12, 2024): https://docs.dipy.org/1.10.0/api_changes.html#dipy-1-10-0-changes Fixes: ``` src/nifreeze/testing/simulations.py:181: UserWarning: Pass ['bvecs'] as keyword args. From version 2.0.0 passing these as positional arguments will result in an error. return gradient_table(bvals, bvecs) ``` raised for example in: https://github.com/nipreps/nifreeze/actions/runs/12457578962/job/34772277392?pr=35#step:12:1015
jhlegarreta
force-pushed
the
CallDIPYFuncsWithKeywordArgs
branch
from
ae3c539 to
bc347ed
Compare
jhlegarreta
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 65.84% 65.84%
=======================================
Files 18 18
Lines 931 931
Branches 119 119
=======================================
Hits 613 613
Misses 274 274
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass parameters as keyword arguments when calling DIPY functions and methods that have keyword arguments: DIPY has transitioned to keyword-only arguments for these starting version 1.10.0 (released Dec 12, 2024):
https://docs.dipy.org/1.10.0/api_changes.html#dipy-1-10-0-changes
Fixes:
raised for example in:
https://github.com/nipreps/nifreeze/actions/runs/12457578962/job/34772277392?pr=35#step:12:1015