ENH: Remove math.utils module
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: d65a001 no tags/releases exist yet, so we are not breaking the API. |
|
Leaving the semidefinite positiveness check function in case we decide to call it from the covariance matrix construction methods. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Scikit-learn checks this internally. I think it can safely go away :) |
jhlegarreta
force-pushed
the
MoveMathUtilsTestingToRoot
branch
from
d65a001 to
0c95d93
Compare
jhlegarreta
changed the title
math.utils testing to root test foldermath.utils module
Removed. |
Remove the `math.utils` module: - The positive semidefinite check for the kernels is built-in in `scikit-learn` `GaussianProcessRegressor` class: https://github.com/dalmia/scikit-learn/blob/598c651afd987a540e404ccdb3491d530e0b0abb/sklearn/gaussian_process/gpr.py#L245 - The `math.utils.compute_angle` function, as it was superseded by `model.gpr.compute_pairwise_angles`.
jhlegarreta
force-pushed
the
MoveMathUtilsTestingToRoot
branch
from
0c95d93 to
2b6e33e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
math.utilsmodule:scikit-learnGaussianProcessRegressorclass:https://github.com/dalmia/scikit-learn/blob/598c651afd987a540e404ccdb3491d530e0b0abb/sklearn/gaussian_process/gpr.py#L245
math.utils.compute_anglefunction, as it was superseded bymodel.gpr.compute_pairwise_angles.