Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Generate composite transforms with --multi-step-reg #425

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Jan 6, 2025

This PR adjusts the transform produced from the multi-step registration workflow to be a composite transform.

In #415, antsApplyTransform was used to create a single displacement field from native -> template space, producing inconsistent output transform types. This shifts to using CompositeTransformUtil to disassemble each sub-transform and assemble them into a singular composite h5 file.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56.13%. Comparing base (f95e40b) to head (f327dd6).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/interfaces/patches.py 59.25% 11 Missing ⚠️
nibabies/workflows/anatomical/registration.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   56.17%   56.13%   -0.04%     
==========================================
  Files          70       70              
  Lines        6653     6682      +29     
  Branches      827      832       +5     
==========================================
+ Hits         3737     3751      +14     
- Misses       2712     2727      +15     
  Partials      204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd marked this pull request as ready for review January 7, 2025 15:50
@mgxd mgxd merged commit 9acda6b into nipreps:master Jan 8, 2025
14 of 16 checks passed
@mgxd mgxd deleted the fix/composite-xfms branch January 8, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant