Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Separate anatomical preproc output from file used for registration #423

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Dec 19, 2024

Closes #422

  • Do not save anatomical preproc that has had CSF normalized (if --norm-csf has been enabled)
  • Changes anat_preproc_buffer to anat_reg_buffer to better show its purpose

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.01%. Comparing base (86264fe) to head (89df65a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/anatomical/fit.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   56.17%   56.01%   -0.16%     
==========================================
  Files          70       70              
  Lines        6653     6653              
  Branches      827      827              
==========================================
- Hits         3737     3727      -10     
- Misses       2712     2722      +10     
  Partials      204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd marked this pull request as ready for review December 20, 2024 12:48
@mgxd mgxd merged commit 7813345 into nipreps:master Dec 20, 2024
14 of 16 checks passed
@mgxd mgxd deleted the fix/preproc-normcsf branch December 20, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output non-normalized preproc if --norm-csf is used
1 participant