Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Default surface recon method should be None #416

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Dec 12, 2024

None was correctly being set from the parser, but the configuration was not being set since Nones are skipped.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.21%. Comparing base (7efc8c9) to head (ea2355b).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7efc8c9) and HEAD (ea2355b). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (7efc8c9) HEAD (ea2355b)
7 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #416       +/-   ##
===========================================
- Coverage   55.89%   38.21%   -17.68%     
===========================================
  Files          68       68               
  Lines        6477     6477               
  Branches      809      809               
===========================================
- Hits         3620     2475     -1145     
- Misses       2658     3915     +1257     
+ Partials      199       87      -112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd merged commit ed90a8c into nipreps:master Dec 12, 2024
5 of 16 checks passed
@mgxd mgxd deleted the fix/no-recon branch December 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant