STY: Add *Ruff* config and fix all warnings and errors #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
sty/ruff
branch
2 times, most recently
from
3824cfb to
6a792ed
Compare
This was referenced Mar 20, 2024
|
@oesteban Do you intend to add a CI job for ruff, in addition to or instead of the flake8 CI job? |
|
Yup, happy to review a PR :) |
|
I guess instead of flake8? |
|
Also, while I am not a big fan of .pre-commit, it is recommended by Repo-Review: How about adding support for .pre-commit instead of explicitly running a ruff job? |
|
I would prefer to stay away from pre-commit. It places some burden on the contributor to set it up and I don't love how the project is driven. The only gain is averting some CI tests to fail. I think we can live with that. |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.