-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: New version of the rating widget #1012
Conversation
@rwblair ratings are not integers on a Likert scale anymore, now we need to store floats - is that possible in the current MRIQCwebapi schema? We probably want to add the collection of the elapsed time rating and the rater's confidence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @oesteban,
This looks great! What about extending the list of artifacts with some of my suggestion from issue #1009 ? (cf discussion there)
Let's address that on a different PR. |
Changes with this PR: - Updates Bootstrapjs to version 5.0.2 - Updates jQuery to version 3.6.0 - Updates some components of bootstrap for the new version - Convert the rating widget into a range slider allowing interval ratings. - Reduce the space the widget takes with an accordion - Make the rating widget invisible at the start - Add a field for comments and a slider for rater confidence - Add a timer, which is also reported within the JSON object. Resolves: #1007. Resolves: #1008.
b86f75d
to
60f0ee6
Compare
@oesteban looks like ratings coming in to web api are cast as strings to be as flexible as possible. |
There are two new fields we probably want to also submit:
Does that mean that the API could also accept nonnumerical values? Do we know if someone has tried to push garbage in? |
Someone could post nonnumerical ratings, I have not looked to see if its been abused yet. So the historic way of adding fields, as you have done, is embedding them in the comment field, |
schema definition for ratings for context: |
My dump of ratings from 05/27 only contains single digit ratings from 1 to 4. |
Changes with this PR:
ratings.
Resolves: #1007.
Resolves: #1008.
New look and feel: