Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: New version of the rating widget #1012

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

oesteban
Copy link
Member

Changes with this PR:

  • Updates Bootstrapjs to version 5.0.2
  • Updates jQuery to version 3.6.0
  • Updates some components of bootstrap for the new version
  • Convert the rating widget into a range slider allowing interval
    ratings.
  • Reduce the space the widget takes with an accordion
  • Make the rating widget invisible at the start
  • Add a field for comments and a slider for rater confidence
  • Add a timer, which is also reported within the JSON object.

Resolves: #1007.
Resolves: #1008.

New look and feel:
new-rating-widget

@oesteban
Copy link
Member Author

@rwblair ratings are not integers on a Likert scale anymore, now we need to store floats - is that possible in the current MRIQCwebapi schema?

We probably want to add the collection of the elapsed time rating and the rater's confidence.

Copy link
Collaborator

@celprov celprov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @oesteban,
This looks great! What about extending the list of artifacts with some of my suggestion from issue #1009 ? (cf discussion there)

@oesteban
Copy link
Member Author

Hey @oesteban, This looks great! What about extending the list of artifacts with some of my suggestion from issue nipreps/nireports#92 ? (cf discussion there)

Let's address that on a different PR.

Changes with this PR:

- Updates Bootstrapjs to version 5.0.2
- Updates jQuery to version 3.6.0
- Updates some components of bootstrap for the new version
- Convert the rating widget into a range slider allowing interval
  ratings.
- Reduce the space the widget takes with an accordion
- Make the rating widget invisible at the start
- Add a field for comments and a slider for rater confidence
- Add a timer, which is also reported within the JSON object.

Resolves: #1007.
Resolves: #1008.
@oesteban oesteban force-pushed the enh/new-rating-widget branch from b86f75d to 60f0ee6 Compare August 12, 2022 14:27
@oesteban oesteban merged commit e1bd2cd into master Aug 12, 2022
@oesteban oesteban deleted the enh/new-rating-widget branch August 12, 2022 15:03
@rwblair
Copy link
Contributor

rwblair commented Aug 25, 2022

@oesteban looks like ratings coming in to web api are cast as strings to be as flexible as possible.

@oesteban
Copy link
Member Author

There are two new fields we probably want to also submit:

  • rating time (the widget now has a timer to know how much time was spent on the report)
  • rater confidence

@oesteban looks like ratings coming in to web api are cast as strings to be as flexible as possible.

Does that mean that the API could also accept nonnumerical values? Do we know if someone has tried to push garbage in?

@rwblair
Copy link
Contributor

rwblair commented Aug 25, 2022

Someone could post nonnumerical ratings, I have not looked to see if its been abused yet.

So the historic way of adding fields, as you have done, is embedding them in the comment field, which is a hack to say the least (*no need to be snippy its how we got away with allowing for easy expansion of rating widget). I need to think about how we can make this better and what all it would take. While still being backwards compatible.

@rwblair
Copy link
Contributor

rwblair commented Aug 25, 2022

@rwblair
Copy link
Contributor

rwblair commented Aug 25, 2022

My dump of ratings from 05/27 only contains single digit ratings from 1 to 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (To be released)
Development

Successfully merging this pull request may close these issues.

Rating widget: add a stopwatch and record screening time Rating widget: change to continous scale
3 participants