Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Repair and test query for precalculated baseline/boldref files #3370

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

psadil
Copy link
Contributor

@psadil psadil commented Oct 2, 2024

Changes proposed in this pull request

Following through with suggested change: #3369 (review); previously, precalculated baseline/boldref niftis would not be found.

Documentation that should be reviewed

@psadil psadil changed the title Fix/derivatives baseline suffix Fix: Repair and test query for precalculated baseline/boldref files Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.70%. Comparing base (1a9ccce) to head (c568a7b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
+ Coverage   71.59%   71.70%   +0.11%     
==========================================
  Files          57       57              
  Lines        4249     4259      +10     
  Branches      639      640       +1     
==========================================
+ Hits         3042     3054      +12     
+ Misses       1091     1090       -1     
+ Partials      116      115       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psadil psadil force-pushed the fix/derivatives-baseline-suffix branch from 214d66c to c568a7b Compare October 2, 2024 15:28
@effigies effigies merged commit 9ea1665 into nipreps:master Oct 2, 2024
18 checks passed
@psadil psadil deleted the fix/derivatives-baseline-suffix branch October 2, 2024 16:47
effigies added a commit that referenced this pull request Oct 12, 2024
24.1.1 (October 10, 2024)

Bug fix release in the 24.1.x series.

Precomputed functional derivatives were not being correcly detected,
and a couple fixes for rare issues.

  * FIX: Remove checks for unit zooms and symmetric rotations in template warp (#3376)
  * FIX: Stop excluding FS minc_modify_header used during fallback registration (#3372)
  * FIX: Repair search for precomputed bold references (#3370)
  * FIX: Repair search for precomputed transforms (#3369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants