Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: docker db size warning #1856

Closed
wants to merge 1 commit into from

Conversation

erramuzpe
Copy link
Contributor

Changes proposed in this pull request

Warning in docs about this satanic issue poldracklab/mriqc#666 😈

Documentation that should be reviewed

It's a matter of if you like the chunk of code inside the warning or not

@auto-comment

This comment has been minimized.

@erramuzpe
Copy link
Contributor Author

I will also send a PR for mriQC

Changing the maximum size of the container will solve it: ::

$ service docker stop
$ dockerd --storage-opt dm.basesize=30G
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should specify what OS/service managers this works with. I'm guessing it's systemd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is an issue of the working directory not being mounted, shall we just discard it? Or change the warning to "make sure you mounted the working dir"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t might be worth mentioning something about the memory allocated here ? Could optionally link out:
https://docs.docker.com/config/containers/resource_constraints/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if we're adding warnings, but +1 on clarifying re working directory being mounted !)

@oesteban
Copy link
Member

@erramuzpe may I ask you to:

  • add the warning first that we recommend mounting a work directory
  • then, if the user does not want to mount the work directory for whatever reason, keep the modifications you already have included in the pr, but indicating that we do not advise this route.
  • Add a link to the documentation bit that @emdupre suggested above.

@erramuzpe
Copy link
Contributor Author

Sorry @oesteban I was completely out for the last month, will work on this in the following weeks

@oesteban
Copy link
Member

oesteban commented Jun 5, 2020

The general documentation about containers has been moved over to nipreps.org (in particular, Docker here - https://www.nipreps.org/apps/docker/). The end goal is to identify commonalities and unify the documentation across different projects (fMRIPrep, MRIQC, dMRIPrep...).

This particular fix is relevant, since it has already been pushed in MRIQC's documentation. Please send a PR from https://github.com/nipreps/nipreps.github.io/blob/mkdocs/docs/apps/docker.md .

I'll close this PR in favor of the new documentation site. Please move there all the conversation about what is the best advice we can give to go around this issue.

@oesteban oesteban closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants