Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define padded mixing arr if skip_vols are 0 #69

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Define padded mixing arr if skip_vols are 0 #69

merged 1 commit into from
Sep 20, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Sep 20, 2024

Closes none. This fixes a bug where ica_aroma_confound_extraction will fail if skip_vols is 0.

@tsalo tsalo added the bug Something isn't working label Sep 20, 2024
@tsalo tsalo merged commit 24a0dcf into main Sep 20, 2024
9 of 10 checks passed
@tsalo tsalo deleted the fix-more branch September 20, 2024 18:10
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.85%. Comparing base (99bf9ca) to head (eed7389).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/interfaces/confounds.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   30.87%   30.85%   -0.02%     
==========================================
  Files          26       26              
  Lines        2329     2330       +1     
  Branches      365      365              
==========================================
  Hits          719      719              
- Misses       1589     1590       +1     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant