Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out compressed denoised files #41

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Write out compressed denoised files #41

merged 4 commits into from
Aug 6, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Aug 6, 2024

Changes proposed in this pull request

  • Compress the denoised output files.
  • Fix order of entities.
  • Add res to the denoised files.

Documentation that should be reviewed

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.18%. Comparing base (41fdb30) to head (562a418).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/workflows/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   31.18%   31.18%           
=======================================
  Files          26       26           
  Lines        2155     2155           
  Branches      327      327           
=======================================
  Hits          672      672           
  Misses       1463     1463           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 6, 2024

Updated tree (I dropped the second session):

├── dataset_description.json
├── logs
│   ├── CITATION.bib
│   ├── CITATION.html
│   ├── CITATION.md
│   └── CITATION.tex
├── sub-01
│   └── ses-01
│       ├── figures
│       │   ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-aroma_bold.svg
│       │   ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-metrics_bold.svg
│       │   ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-about_bold.html
│       │   └── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-summary_bold.html
│       └── func
│           ├── sub-01_ses-01_task-rest_desc-aroma_metrics.json
│           ├── sub-01_ses-01_task-rest_desc-aroma_metrics.tsv
│           ├── sub-01_ses-01_task-rest_desc-melodic_timeseries.tsv
│           ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-aggrDenoised_bold.nii.gz
│           ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-melodic_components.nii.gz
│           ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-melodic_mixing.tsv
│           ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-nonaggrDenoised_bold.nii.gz
│           └── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_res-2_desc-orthaggrDenoised_bold.nii.gz
└── sub-01.html

@tsalo tsalo merged commit 4bd4e0c into nipreps:main Aug 6, 2024
10 checks passed
@tsalo tsalo deleted the compress-denoised branch August 6, 2024 20:15
@tsalo tsalo added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant