Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denoise MNI152NLin6Asym:res-2 #40

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Denoise MNI152NLin6Asym:res-2 #40

merged 3 commits into from
Aug 6, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Aug 6, 2024

Related to #39.

Changes proposed in this pull request

  • Write out denoised MNI152NLin6Asym data. --output-spaces still isn't supported.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 31.18%. Comparing base (02654df) to head (0a2674a).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/workflows/base.py 0.00% 7 Missing ⚠️
src/fmripost_aroma/workflows/aroma.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   31.02%   31.18%   +0.15%     
==========================================
  Files          26       26              
  Lines        2166     2155      -11     
  Branches      329      327       -2     
==========================================
  Hits          672      672              
+ Misses       1474     1463      -11     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 6, 2024

New tree:

.
├── dataset_description.json
├── logs
│   ├── CITATION.bib
│   ├── CITATION.html
│   ├── CITATION.md
│   └── CITATION.tex
├── sub-01
│   ├── ses-01
│   │   ├── figures
│   │   │   ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-about_bold.html
│   │   │   ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-aroma_bold.svg
│   │   │   ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-metrics_bold.svg
│   │   │   └── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-summary_bold.html
│   │   └── func
│   │       ├── sub-01_ses-01_task-rest_desc-aroma_metrics.json
│   │       ├── sub-01_ses-01_task-rest_desc-aroma_metrics.tsv
│   │       ├── sub-01_ses-01_task-rest_desc-melodic_timeseries.tsv
│   │       ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-aggrDenoised_bold.nii
│   │       ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-melodic_components.nii.gz
│   │       ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-melodic_mixing.tsv
│   │       ├── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-nonaggrDenoised_bold.nii
│   │       └── sub-01_ses-01_task-rest_space-MNI152NLin6Asym_desc-orthaggrDenoised_bold.nii
│   └── ses-02
│       ├── figures
│       │   ├── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-aroma_bold.svg
│       │   └── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-metrics_bold.svg
│       └── func
│           ├── sub-01_ses-02_task-rest_desc-aroma_metrics.json
│           ├── sub-01_ses-02_task-rest_desc-aroma_metrics.tsv
│           ├── sub-01_ses-02_task-rest_desc-melodic_timeseries.tsv
│           ├── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-aggrDenoised_bold.nii
│           ├── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-melodic_components.nii.gz
│           ├── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-melodic_mixing.tsv
│           ├── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-nonaggrDenoised_bold.nii
│           └── sub-01_ses-02_task-rest_space-MNI152NLin6Asym_desc-orthaggrDenoised_bold.nii
├── sub-01_anat.html
├── sub-01_ses-01_func.html
└── sub-01_ses-02_func.html

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 6, 2024

Not sure why there's no res entity or why the files aren't compressed...

@tsalo tsalo merged commit 41fdb30 into nipreps:main Aug 6, 2024
11 of 12 checks passed
@tsalo tsalo deleted the denoise-mni152nlin6 branch August 6, 2024 19:20
@effigies
Copy link
Member

effigies commented Aug 6, 2024

You probably need to set compress=True on the derivativesdatasink.

@tsalo
Copy link
Collaborator Author

tsalo commented Aug 6, 2024

Thanks!

@tsalo tsalo added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants