-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AROMA classifier #18
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Need to actually make it correct.
@effigies I'm thinking it's time for me to write a test or two of the workflow I'm adding here. I'm thinking of just running fMRIPrep on a single subject's data in "full" mode and uploading the relevant derivatives to Box to use as test data. Do you have any recommendations for OpenNeuro datasets to grab from? EDIT: I'm going to go with 28andHe since I'm planning to play with it at some point anyway. |
It still fails to build though.
There are probably a lot of things I can do to improve the AROMA outputs (e.g., I ended up moving the component metadata, like variance explained, into a TSV that could maybe be moved back into the JSON), but I think the only thing I need to do to actually get the AROMA workflow running is modify the DerivativesDataSink to support the ICA outputs. |
I don't know what's happening with the mock_config, but everything else looks good to me. |
We can use https://gin.g-node.org/tsalo/ds005115-fmriprep-test as the base test data for the AROMA and denoising workflow, since it's a small dataset (50 volumes). Just need to write up a job to grab the data and a test to run the pipeline. |
Merging now. |
Closes #5.
I took the metric and classifier code from ME-ICA/aroma for this.
Changes proposed in this pull request