Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

ENH: Outsource leave-one-out splitter so it can be used across data types #98

Merged
merged 34 commits into from
Apr 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5f13501
Starting to refactor logo_split
teresamg Nov 30, 2022
7fa9b05
Fixed flake8 errors
teresamg Nov 30, 2022
5956168
Moved h5 file read
teresamg Nov 30, 2022
bc14820
Pull dwframe, bframe, bvec into estimator.py
teresamg Dec 1, 2022
200b9f9
Fixed flake8 errors
teresamg Dec 1, 2022
38b4276
Starting to refactor logo_split
teresamg Nov 30, 2022
56f9fd0
Moved h5 file read
teresamg Nov 30, 2022
6aeb4d7
Pull dwframe, bframe, bvec into estimator.py
teresamg Dec 1, 2022
1d5c6ea
Fixed flake8 errors
teresamg Dec 1, 2022
26a0dc4
Preallocate em_affines as array, not Affine object
teresamg Dec 8, 2022
c0693a1
Removed orig copy of dwdata
teresamg Dec 8, 2022
2140673
enh: move logo_split to new submodule
oesteban Dec 15, 2022
374864a
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
bc845d9
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
6191fa1
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
175d1dd
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
cb19fb1
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
64ccc58
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
88bf1dc
Update src/eddymotion/data/splitting.py
teresamg Dec 15, 2022
a3a3f1b
Fixed logo_split() call and dwdata->data
teresamg Dec 15, 2022
f18029e
Updated set_transform(), removed pbar grad_str text
teresamg Dec 15, 2022
a8538bf
fix: revise merge conflicts and get ready for final revision
oesteban Mar 27, 2024
542caa8
fix: revert accidental removal of two lines
oesteban Mar 27, 2024
82a557e
Apply suggestions from code review
esavary Mar 27, 2024
d45ec01
fix: Restore access to HDF5 file
esavary Mar 27, 2024
e776155
fix: Restore b0 argument
esavary Mar 27, 2024
b4a18ad
fix: typos
esavary Mar 27, 2024
3a96d51
Add: test for lovo_split
esavary Mar 28, 2024
1d6762c
Fix: remove unused import
esavary Mar 28, 2024
bcff16d
Apply suggestions from code review
esavary Mar 28, 2024
316eb57
Fix: return test data and gradient
esavary Mar 28, 2024
4217635
Fix: typo
esavary Mar 28, 2024
14cd4d0
Fix: masking
esavary Mar 28, 2024
9591b81
Update src/eddymotion/estimator.py
esavary Mar 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed flake8 errors
teresamg authored and oesteban committed Mar 27, 2024

Verified

This commit was signed with the committer’s verified signature.
oesteban Oscar Esteban
commit 1d5c6eac7ea7e059329970f2ff017946062b0205
4 changes: 2 additions & 2 deletions src/eddymotion/data/dmri.py
Original file line number Diff line number Diff line change
@@ -122,7 +122,7 @@ class DWI:
def __len__(self):
"""Obtain the number of high-*b* orientations."""
return self.dataobj.shape[-1]

def set_data(self):
# Generate dwframe and bframe
if not Path(self._filepath).exists():
@@ -131,7 +131,7 @@ def set_data(self):
# read original DWI data & b-vector
with h5py.File(self._filepath, "r") as in_file:
self._root = in_file["/0"]

def set_transform(self, dwframe, bvec, index, affine, order=3):
oesteban marked this conversation as resolved.
Show resolved Hide resolved
"""Set an affine, and update data object and gradients."""
reference = namedtuple("ImageGrid", ("shape", "affine"))(
1 change: 0 additions & 1 deletion src/eddymotion/estimator.py
Original file line number Diff line number Diff line change
@@ -35,7 +35,6 @@

from eddymotion.dmri import logo_split
from eddymotion.model import ModelFactory
from eddymotion.dmri import logo_split


class EddyMotionEstimator: