Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

STYLE: Make Kriging hyperparameter property naming consistent #260

Merged

Conversation

jhlegarreta
Copy link
Collaborator

Make Kriging hyperparameter property naming consistent: use hyperparameter_l instead of hyperparameter_beta_l for the beta_l hyperparameter, much like hyperparameter_a is being used for the beta_a hyperparameter.

Make Kriging hyperparameter property naming consistent: use
`hyperparameter_l` instead of `hyperparameter_beta_l` for the `beta_l`
hyperparameter, much like `hyperparameter_a` is being used for the
`beta_a` hyperparameter.
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (c2cd536) to head (f7b1e04).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          19       19           
  Lines         942      942           
  Branches      119      119           
=======================================
  Hits          624      624           
  Misses        274      274           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

effigies commented Dec 9, 2024

Does anything depend on these? This is an API change, but I don't know the scope of the impact.

@jhlegarreta
Copy link
Collaborator Author

jhlegarreta commented Dec 9, 2024

Does anything depend on these?

I would like @oesteban to review this and check the https://github.com/nipreps/eddymotion/blob/main/docs/notebooks/dwi_gp_estimation.ipynb notebook. I cannot check it myself because the data is yet to be shared in the repository. It was found out by Óscar that scikit-learn follows an alphabetical order when processing the kernel hyperparameters/parameters and thus he added the beta_ prefix.

This is an API change, but I don't know the scope of the impact.

We had not released a version with the previous API so I believe we are allowed to break the API at this stage.

oesteban
oesteban previously approved these changes Dec 19, 2024
@oesteban oesteban merged commit df49081 into nipreps:main Dec 19, 2024
8 checks passed
@jhlegarreta jhlegarreta deleted the IncreaseGPRHpmPropertyNamingConsistency branch December 19, 2024 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants