This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
ENH: Miscellaneous improvements to the scripts #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jhlegarreta
commented
Oct 26, 2024
jhlegarreta
commented
- ENH: Miscellaneous improvements to the scripts
- ENH: Compute the number of CV repetitions dynamically
- DOC: Improve consistency in script function docstring
Miscellaneous improvements to the scripts: - Make the b-value parameter be an integer. - Remove storing the generated dMRI signal/gtab and predictions from the error analysis plot and constrain the script to the CV error analysis. - Make the error analysis script main method description honor its new purpose. - Store the generated signal b-value in the error analysis script so that it can be added to the plot title. - Remove plotting the predicted signal from the error analysis plot script. - Make the error analysis plot script main method description honor its purpose. - Print the generated signal b-value in the error analysis plot title. - Add a script to generate a synthetic signal and predict using a GP. Store the generated dMRI signal/gtab and the predictions. - Add a script to plot the generated synthetic signal and the GP predictions. - Rename the GP error analysis plot script so that it honors better its scope now.
Compute the number of CV repetitions dynamically by setting the number to the maximum number of folds requested by the user.
Improve consistency in script function docstring: use sentence style (start with capitals and end with period).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 19 19
Lines 905 905
Branches 112 112
=======================================
Hits 599 599
Misses 264 264
Partials 42 42 ☔ View full report in Codecov by Sentry. |
oesteban
approved these changes
Oct 28, 2024
|
Will adjust the covariance parameter values as the scripts are improved to provide the plots that we would like to have or once we get a clearer picture of what is wrong with the simulated signals. Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.