Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

MAINT: Move test data files to a dedicated folder inside test folder #236

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jhlegarreta
Copy link
Collaborator

@jhlegarreta jhlegarreta commented Oct 8, 2024

Move test data files to a dedicated folder inside the test folder, and edit accordingly the _datadir path used across doctests and examples.

Fixes #233.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.18%. Comparing base (a61c5e1) to head (63d64ab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files          19       19           
  Lines         905      905           
  Branches      112      112           
=======================================
  Hits          599      599           
  Misses        264      264           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta jhlegarreta force-pushed the MoveActualDataOutsideSrc branch from 6eeb736 to 89dc3e0 Compare October 8, 2024 22:50
@oesteban
Copy link
Member

These are test-data files, would it make sense to move them into /test/ instead?

@jhlegarreta
Copy link
Collaborator Author

These are test-data files, would it make sense to move them into /test/ instead?

I don't have a strong preference, but in order to keep the code separated from the data, if we move these files to the test folder, I would move them to test/data. Let me know if you feel comfortable with this. Thanks.

@oesteban
Copy link
Member

oesteban commented Oct 23, 2024 via email

Move test data files to a dedicated folder inside the `test` folder, and
edit accordingly the `_datadir` path used across doctests and examples.
@jhlegarreta jhlegarreta force-pushed the MoveActualDataOutsideSrc branch from 89dc3e0 to 63d64ab Compare October 23, 2024 13:31
@jhlegarreta jhlegarreta changed the title MAINT: Move actual data files outside the source tree MAINT: Move test data files to a dedicated folder inside test folder Oct 23, 2024
@oesteban oesteban merged commit 7414275 into nipreps:main Oct 23, 2024
8 checks passed
@jhlegarreta jhlegarreta deleted the MoveActualDataOutsideSrc branch October 23, 2024 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relocate actual data in data module to elsewhere
2 participants