-
Notifications
You must be signed in to change notification settings - Fork 16
DOC: Improve the copyright notice information in the LICENSE
file
#235
DOC: Improve the copyright notice information in the LICENSE
file
#235
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 63.97% 64.08% +0.11%
==========================================
Files 18 18
Lines 905 905
Branches 154 117 -37
==========================================
+ Hits 579 580 +1
Misses 282 282
+ Partials 44 43 -1 ☔ View full report in Codecov by Sentry. |
ac29057
to
1db693e
Compare
Have been thinking and reading more about this:
So despite the comment about the year in the 17 U.S. Code § 401 mentioned in https://opensource.stackexchange.com/a/5779, it looks like dropping the year would be OK as mentioned at the Tech Monitoring meeting on Oct 1 2024. Did not add a reference to the LICENSE file though, and followed what the instructions say. the LICENSE file contains anyways the same information as the URL that is pointed on every file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple minor suggestions.
Improve the copyright notice information: - Introduce a `NOTICE` file to hold the copyright information: state the original year (2021) in which works were first released and use `-present` to avoid any need to update the year at every release. - Remove the license application instructions from the `LICENSE` file. - Remove the copyright year from every other source file.
Update `NOTICE` to contain the Apache license notice paragraph. Co-authored-by: Chris Markiewicz <[email protected]>
2189cf5
to
0a1f560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Given that I proposed removing the license appendix, I'll let someone else merge, if they agree.
The `NOTICE` file text is not a repetition of the license banner, but clarifications about the licensing of the code (e.g., if in the past had other licenses, or if it derives from pre-exiting code). Thus, remove the license information and edit the text to reflect the copyright of the code. Co-authored-by: Oscar Esteban <[email protected]>
Specify years in the copyright text of the `NOTICE` file.
e91feaa
to
8340d37
Compare
Remove "present" as ending year from copyright NOTICE: it does not add relevant information/it is implicit. Co-authored-by: Oscar Esteban <[email protected]>
Improve the copyright notice information in the
LICENSE
file: make the notice specific to this repository and avoid any variability in the notices by removing the placeholders:LICENSE
file.Apply the above changes to the copyright notices across source files.