Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

MAINT: Adopt tox for testing environment configuration #234

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jhlegarreta
Copy link
Collaborator

@jhlegarreta jhlegarreta commented Oct 5, 2024

Adopt tox for testing environment configuration as per decision at the Oct 1 2024 Technical Monitoring meeting.

Add the necessary tox.ini file and edit the GHA test.yml workflow file to use tox, to use ants, to use DataLad to download the testing data, and to cache the data across the build matrix.

Pin nitransforms to <24 following commit d26541b. The decision on pinning to <24 was made following consistent failures on test_proximity_estimator_trivial_model, e.g.
https://github.com/nipreps/eddymotion/actions/runs/11123784605/job/30907972182#step:8:196
and
https://github.com/nipreps/eddymotion/actions/runs/11203922080/job/31141711676?pr=234#step:12:342

The version was pinned for the conda env.yml config file, but not pyproject.toml.

@jhlegarreta jhlegarreta force-pushed the AdoptToxTestingEnvConfig branch from f3341ab to 17a4546 Compare October 6, 2024 00:06
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.97%. Comparing base (b1d9928) to head (342c7fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   63.97%   63.97%           
=======================================
  Files          18       18           
  Lines         905      905           
  Branches      154      164   +10     
=======================================
  Hits          579      579           
  Misses        282      282           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta jhlegarreta force-pushed the AdoptToxTestingEnvConfig branch 8 times, most recently from b93c5ce to 77f2b97 Compare October 6, 2024 00:50
@jhlegarreta
Copy link
Collaborator Author

jhlegarreta commented Oct 6, 2024

@oesteban I am missing something with ANTs: looks like ANTs is not being searched/I am not passing the ANTSPATH properly:
https://github.com/nipreps/eddymotion/actions/runs/11197606677/job/31127816540?pr=234#step:12:595

I have checked where miniconda is downloading it: https://github.com/nipreps/eddymotion/actions/runs/11197535087/job/31127651103#step:6:1

And I believe I am trying to pass its value to tox:
https://github.com/nipreps/eddymotion/pull/234/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R96
https://github.com/nipreps/eddymotion/pull/234/files#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449R34

Do you happen to know off the top of your head how to fix this? Thanks.


Edit: Fixed the issues with ANTs and pinned nitransforms to get past the test_proximity_estimator_trivial_model failure.

Ready to be merged.

@jhlegarreta jhlegarreta force-pushed the AdoptToxTestingEnvConfig branch 4 times, most recently from 87b7873 to 0303064 Compare October 7, 2024 22:07
Adopt `tox` for testing environment configuration as per decision at the
Oct 1 2024 Technical Monitoring meeting.

Add the necessary `tox.ini` file and edit the GHA `test.yml` workflow
file to use `tox`, to use `ants`, to use `DataLad` to download the
testing data, and to cache the data across the build matrix.

Pin `nitransforms` to <24 following commit d26541b. The decision on
pinning to <24 was made following consistent failures on
`test_proximity_estimator_trivial_model`, e.g.
https://github.com/nipreps/eddymotion/actions/runs/11123784605/job/30907972182#step:8:196
and
https://github.com/nipreps/eddymotion/actions/runs/11203922080/job/31141711676?pr=234#step:12:342

The version was pinned for the conda `env.yml` config file, but not
`pyproject.toml`.
Increase consistency in dependency pinning specification: remove spaces
and adopt compact notation for `nipype` in `pyproject.toml` as used for
the rest of the dependencies.
@jhlegarreta jhlegarreta force-pushed the AdoptToxTestingEnvConfig branch from 0303064 to 342c7fc Compare October 7, 2024 22:08
@oesteban oesteban merged commit c873ba6 into nipreps:main Oct 23, 2024
14 checks passed
@jhlegarreta jhlegarreta deleted the AdoptToxTestingEnvConfig branch October 23, 2024 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants